Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show timeline preview from 0:00 to 0:00 in 1h blocks #966

Closed
tijlleenders opened this issue Jan 26, 2023 · 5 comments · Fixed by #988
Closed

Show timeline preview from 0:00 to 0:00 in 1h blocks #966

tijlleenders opened this issue Jan 26, 2023 · 5 comments · Fixed by #988
Assignees
Labels
enhancement New feature or request UI User-Interface

Comments

@tijlleenders
Copy link
Owner

tijlleenders commented Jan 26, 2023

image

Space should be proportional to allocated time. So 24 equal units for 24 hours.

If proportional doesn't come out right the first 6 hours (0-6) of the day could get a little less space.

@tijlleenders tijlleenders added UI User-Interface enhancement New feature or request labels Jan 26, 2023
@tijlleenders tijlleenders changed the title Show timeline preview from 0:00 to 0:00 Show timeline preview from 0:00 to 0:00 in 1h blocks Feb 2, 2023
@Tushar-4781 Tushar-4781 self-assigned this Feb 3, 2023
@tijlleenders tijlleenders reopened this Feb 4, 2023
@tijlleenders
Copy link
Owner Author

tijlleenders commented Feb 4, 2023

@Tushar-4781
The way a single hour is scheduled is misleading. The timeline says the whole day is taken.

Please just divide the timeline in 24 blocks and show realistically what a day looks like instead of distorting for better overview.

Screenshot_1h.jpg

@tijlleenders
Copy link
Owner Author

tijlleenders commented Feb 4, 2023

We currently have the logic for 'cutting the schedule into days' in the frontend.

A better place would be to to this in the backend.

Rationale: One could argue this is a presentation concern... but since a scheduler call is always for a timezone-localized UI - but there is no use case for having the display differ from what the scheduler outputs. Output first time right. This would require the input to the scheduler to include the timezone of the requested calendar - and the output to include the 'free' time.

At a later stage individual goals can have differing timezones for frequent travellers and remote distributed teams use cases - but for now we assume one timezone for all goals on a calendar.

@tijlleenders
Copy link
Owner Author

@tijlleenders
Copy link
Owner Author

Blocked by tijlleenders/ZinZen-scheduler#241

@tijlleenders tijlleenders added this to the Company demo milestone Feb 19, 2023
@tijlleenders
Copy link
Owner Author

Closed by #1040

@tijlleenders tijlleenders moved this to Done in ZinZen® May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request UI User-Interface
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants