Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make parameters more reasonable #3749

Open
nolouch opened this issue Jun 7, 2021 · 6 comments
Open

make parameters more reasonable #3749

nolouch opened this issue Jun 7, 2021 · 6 comments
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@nolouch
Copy link
Contributor

nolouch commented Jun 7, 2021

Feature Request

Describe your feature request related problem

We have encountered many problems caused by improper parameter adjustment. We must limit the adjustment range of the parameters and give a best practice, remove some useless and do some check.

Such as: merge-limit=128, region-limit=64, leader-limit=8 the merge limit may influence the leader limit.

Describe alternatives you've considered

  • make the limit do not affect each other
  • limit the adjustment range, such as store limit should have best practice
  • do some check if the user set parameters is unreasonble

Teachability, Documentation, Adoption, Migration Strategy

  • GO
@nolouch nolouch added the type/enhancement The issue or PR belongs to an enhancement. label Jun 7, 2021
@xuhui-lu
Copy link
Contributor

hey @nolouch, may I pick up this issue?

@xuhui-lu
Copy link
Contributor

And I think the limit here means the parameters for scheduler, is my understanding correct?

@nolouch
Copy link
Contributor Author

nolouch commented Jun 14, 2021

@xuhui-lu Yes, you are right. such as store limit. we need to set a reasonable range for some parameters. Do you have any ideas?
PTAL @rleungx @bufferflies

@bufferflies
Copy link
Contributor

I think you should decouple the merge-limit, region-limit, leader-limit first.

@bufferflies
Copy link
Contributor

The relation between limit and scheduler(checker) is below:
image

the relation between opKind and scheduler(checker) is below:
image

@bufferflies
Copy link
Contributor

bufferflies commented Jun 28, 2021

There are some job to solve this problem:

  • one operator only consume one limit, it will consume leader limit if operator include transfer leader and move peer
  • add leader store limit to modify one store's leader limit independent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

3 participants