Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lua Version Request #13

Open
tilkinsc opened this issue Dec 20, 2023 · 5 comments
Open

Lua Version Request #13

tilkinsc opened this issue Dec 20, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@tilkinsc
Copy link
Owner

This thread serves as a Lua version request.
@tilkinsc tilkinsc added the enhancement New feature or request label Dec 20, 2023
@tilkinsc tilkinsc pinned this issue Dec 20, 2023
@tilkinsc tilkinsc changed the title Version Request Lua Version Request Jan 24, 2024
@tilkinsc tilkinsc unpinned this issue Aug 28, 2024
@JustArion
Copy link

Hi there, can Lua 5.0 be added please?

@tilkinsc
Copy link
Owner Author

tilkinsc commented Jan 3, 2025 •
edited
Loading

Hi there, can Lua 5.0 be added please?

There is a branch with Lua 5.0.3 and a dll built for windows. Please test and let me know any bugs. Please note, you will have to manually involve the built dll, as project references just don't work for natives.

@JustArion
Copy link

Hi there, can Lua 5.0 be added please?

There is a branch with Lua 5.0.3 and a dll built for windows. Please test and let me know any bugs. Please note, you will have to manually involve the built dll, as project references just don't work for natives.

It's working fine in my tests. Thanks!

@tilkinsc
Copy link
Owner Author

tilkinsc commented Jan 4, 2025 •
edited
Loading

You are actually using lua5.1 with that code, do a pull I just added some changes where it targets the appropriate dll. While 51 and 50 are very similar there are definitely some differences. I'll push the changes to nuget in 30 days. Changed my phone number and didn't get to change over the 2fa key.

@JustArion
Copy link

JustArion commented Jan 4, 2025 •
edited
Loading

You are actually using lua5.1 with that code, do a pull I just added some changes where it targets the appropriate dll. While 51 and 50 are very similar there are definitely some differences. I'll push the changes to nuget in 30 days. Changed my phone number and didn't get to change over the 2fa key.

I already rebound the Import via NativeLibrary.SetDllImportResolver on "lua515" as it's one of the first things I noticed. I should have mentioned that, my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tilkinsc @JustArion