Replies: 3 comments 1 reply
-
Update: there's a tracking issue in |
Beta Was this translation helpful? Give feedback.
0 replies
-
Micha, I'm going to trust you on this one, I am still way behind on this CI stuff (catching up a bit, but still). I would like us to have all non-failing actions though. |
Beta Was this translation helpful? Give feedback.
1 reply
-
@embano1 Sounds good to me 👍 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
While the newly added benchmark GHA running on PRs to detect regressions gives us some good insights, it is currently hard to parse as we cannot directly alert on a PR due to Github's security model for workflows triggered on
pull_request
.IMHO we could simplify the whole benchmark workflow and make use of Job Summaries if we can get a nicely rendered markdown table from the benchmark output. I am using
tparse
to do this for regulargo test
but haven't looked into it wrtgo test -bench
.I am wondering if we could just adopt
tparse
or something custom we write to get a markdown table for benchmarks which we print on the job summary and have it fail on threshold X. Thoughts? @timbray @yosiatBeta Was this translation helpful? Give feedback.
All reactions