Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advanced API validation #433

Open
timebertt opened this issue Jan 19, 2025 · 0 comments
Open

Add advanced API validation #433

timebertt opened this issue Jan 19, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@timebertt
Copy link
Owner

What would you like to be added:

A validating webhook could be added to the sharder that validates the following aspects of ControllerRing objects:

  • there should be no duplicates in spec.resources[] and spec.resources[].controlledResources[]

Additionally, the webhook could validate shard leases:

  • shard lease names should be RFC 1123 DNS Labels so that they are valid label values (as required for the shard and drain labels)

Why is this needed:

Advanced API validation would prevent misconfiguration and confusion.
Such validation cannot be implemented using CEL validation rules in the ControllerRing CRD.
Also, validation for shard leases can only be added using webhooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog
Development

No branches or pull requests

1 participant