Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tech debt]: Remove detoasting from the compression algorithms as the caller already does this #7716

Open
dbeck opened this issue Feb 17, 2025 · 0 comments
Assignees
Labels
tech-debt Needs refactoring and improvement tasks related to the source code and its architecture.

Comments

@dbeck
Copy link
Contributor

dbeck commented Feb 17, 2025

What type of enhancement is this?

Refactor

What subsystems and features will be improved?

Compression

What does the enhancement do?

As @akuzm pointed out in the review of #7701 , the detoasting is not necessary for bool compression. Because this works the same way for all compression algorithms I don't want to add this change to the mentioned PR, but rather raise a change the consistently addresses the issue across all compression algorithms.

Remove PG_DETOAST_DATUM from ${ALGO}decompression_iterator_from_datum${DIRECTION} and add an assert instead, to make sure it does receive a detoasted Datum.

Implementation challenges

@dbeck dbeck added the enhancement An enhancement to an existing feature for functionality label Feb 17, 2025
@dbeck dbeck self-assigned this Feb 17, 2025
@dbeck dbeck added tech-debt Needs refactoring and improvement tasks related to the source code and its architecture. and removed enhancement An enhancement to an existing feature for functionality labels Feb 17, 2025
@dbeck dbeck changed the title [Enhancement]: Remove detoasting from the compression algorithms as the caller already does this [tech debt]: Remove detoasting from the compression algorithms as the caller already does this Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Needs refactoring and improvement tasks related to the source code and its architecture.
Projects
None yet
Development

No branches or pull requests

1 participant