Upgrade 4.1.9 to 4.1.12 breaks due to non-existant flag --disable-ssl for mysqladmin

[ToshY]

Summary

After upgrading from 4.1.9 to 4.1.12 I've noticed I no longer was getting backups.

mysql-backup-1  | 2025-01-19T09:24:54.435241466Z 2025-01-19.10:24:54 [WARN] ** [01-mysql__redacted] MySQL/MariaDB Server 'mysql' is not accessible, retrying.. (369025 seconds so far)
mysql-backup-1  | 2025-01-19T09:24:59.458481950Z 2025-01-19.10:24:59 [WARN] ** [01-mysql__redacted] MySQL/MariaDB Server 'mysql' is not accessible, retrying.. (369030 seconds so far)
mysql-backup-1  | 2025-01-19T09:25:04.476567389Z 2025-01-19.10:25:04 [WARN] ** [01-mysql__redacted] MySQL/MariaDB Server 'mysql' is not accessible, retrying.. (369035 seconds so far)
mysql-backup-1  | 2025-01-19T09:25:09.498171665Z 2025-01-19.10:25:09 [WARN] ** [01-mysql__redacted] MySQL/MariaDB Server 'mysql' is not accessible, retrying.. (369040 seconds so far)
mysql-backup-1  | 2025-01-19T09:25:14.521217389Z 2025-01-19.10:25:14 [WARN] ** [01-mysql__redacted] MySQL/MariaDB Server 'mysql' is not accessible, retrying.. (369045 seconds so far)
mysql-backup-1  | 2025-01-19T09:25:19.538366501Z 2025-01-19.10:25:19 [WARN] ** [01-mysql__redacted] MySQL/MariaDB Server 'mysql' is not accessible, retrying.. (369050 seconds so far)
mysql-backup-1  | 2025-01-19T09:25:24.556779037Z 2025-01-19.10:25:24 [WARN] ** [01-mysql__redacted] MySQL/MariaDB Server 'mysql' is not accessible, retrying.. (369055 seconds so far)
mysql-backup-1  | 2025-01-19T09:25:29.575533288Z 2025-01-19.10:25:29 [WARN] ** [01-mysql__redacted] MySQL/MariaDB Server 'mysql' is not accessible, retrying.. (369060 seconds so far)
mysql-backup-1  | 2025-01-19T09:25:34.593674390Z 2025-01-19.10:25:34 [WARN] ** [01-mysql__redacted] MySQL/MariaDB Server 'mysql' is not accessible, retrying.. (369065 seconds so far)
mysql-backup-1  | 2025-01-19T09:25:39.611285786Z 2025-01-19.10:25:39 [WARN] ** [01-mysql__redacted] MySQL/MariaDB Server 'mysql' is not accessible, retrying.. (369070 seconds so far)
mysql-backup-1  | 2025-01-19T09:25:44.628691341Z 2025-01-19.10:25:44 [WARN] ** [01-mysql__redacted] MySQL/MariaDB Server 'mysql' is not accessible, retrying.. (369075 seconds so far)
mysql-backup-1  | 2025-01-19T09:25:49.647127798Z 2025-01-19.10:25:49 [WARN] ** [01-mysql__redacted] MySQL/MariaDB Server 'mysql' is not accessible, retrying.. (369080 seconds so far)
mysql-backup-1  | 2025-01-19T09:25:54.662851684Z 2025-01-19.10:25:54 [WARN] ** [01-mysql__redacted] MySQL/MariaDB Server 'mysql' is not accessible, retrying.. (369085 seconds so far)

The logs shown are obfuscating the underlying problem, which is that --disable-ssl is not a valid argument for mysqladmin.

/ # /opt/mysql/bin/mysqladmin -u<redacted> -P3306 -hmysql status
Uptime: 395081  Threads: 3  Questions: 1082677  Slow queries: 23130  Opens: 1807  Flush tables: 3  Open tables: 1741  Queries per second avg: 2.740
/ # /opt/mysql/bin/mysqladmin -u<redacted> -P3306 -hmysql --disable-ssl status
mysqladmin: [ERROR] unknown option '--disable-ssl'.

Steps to reproduce

What is the expected correct behavior?

Relevant logs and/or screenshots

Environment

• Image version / tag: 4.1.12
• Host OS: Ubuntu 22.04

Any logs | docker-compose.yml

Possible fixes

Cause:

docker-db-backup/install/assets/functions/10-db-backup

Line 450 in 244e411

mysql_tls_args="--disable-ssl"

Fix:
Remove ${mysql_tls_args} from the mysqladmin status check

docker-db-backup/install/assets/functions/10-db-backup

Line 975 in 244e411

while ! (run_as_user ${_mysql_prefix}${_mysql_bin_prefix}admin -u"${backup_job_db_user}" -P"${backup_job_db_port}" -h"${backup_job_db_host}" ${mysql_tls_args} status > /dev/null 2>&1) ; do

Related

Similar to #208 / #209

[tiredofit]

Hi, thanks for the investigation..

A quick look at the MySQL settings show that the arguments have deviated from MariaDB and MySQL, to which MySQL uses -ssl-mode=disabled.

I think as opposed to pulling it out entirely we'll have to rework it to support those different command line options as that argument would also break any backups when they executed as well..

As a side note this is being addressed in a different fashion in an upcoming version of the base images, although they are still TBA when they will be in use. I still think the image work is useful.

[ToshY]

Hey @tiredofit

A quick look at the MySQL settings show that the arguments have deviated from MariaDB and MySQL, to which MySQL uses -ssl-mode=disabled.

I think as opposed to pulling it out entirely we'll have to rework it to support those different command line options as that argument would also break any backups when they executed as well..

Ah okay, didn't think to look there 👍 So instead of entirely removing ${mysql_tls_args} it would've been better to change it to --ssl-mode=DISABLED then.

As a side note this is being addressed in a different fashion in an upcoming version of the base images, although they are still TBA when they will be in use. I still think the image work is useful.

Okay, could you tell me in more concrete terms what would you suggest to do with the PR for now? I'm fine with updating the PR with your suggestion, or close it in favor for the (future) base images.

For now I'm still able to use 4.1.9 without any problems in my stacks.

[tiredofit]

Will be back in ~48hr with some thoughts when I can sit down and look at this in detail for a way forward...