New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosine kernel has a missing ^2 #37

Open

chakrah opened this issue Sep 25, 2024 · 0 comments

Collaborator

chakrah commented Sep 25, 2024

Hey,

I think celerite’s cosine amplitude should be amplitude**2 to match the amplitude of cosine george. The function is attached below.

Cheers,
Hritam

def cos(self, data, amplitude, lengthscale):
        """
        CosineKernel implementation in celerite
        """
        amplitude  = amplitude*1e-6 if data == "lc" else amplitude
        log_sigma  = np.log(amplitude**2)
        log_period = np.log(lengthscale)
        return log_sigma, log_period

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment