This repository has been archived by the owner on Jun 8, 2023. It is now read-only.
fix(monorepo): fix babel options resolve #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
1 similar comment
Codecov Report
|
tleunen
reviewed
Jun 7, 2019
| @@ -32,6 +32,7 @@ | |||
| "import" | |||
| ], | |||
| "dependencies": { | |||
| "find-babel-config": "^1.2.0", | |||
There was a problem hiding this comment.
Funny how I was thinking to deprecate the library as there should be a better "official" way of fetching the config now (see babel/babel#7472)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #102
I think I fixed the monorepo cases just the way they worked in babel 6.
EDIT: Though now that I think about it I'm not sure if this is the desired approach. This fixes the breaking change (for some users), but previous lookup by
package.jsonseems more predictable as usually you babelify from child package not the root one. And there's thecwdoption how that should work in monorepo 🧐