Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sphinxneeds available as base docker image #5

Open
twodrops opened this issue Nov 6, 2020 · 2 comments
Open

Make sphinxneeds available as base docker image #5

twodrops opened this issue Nov 6, 2020 · 2 comments

Comments

@twodrops
Copy link
Contributor

twodrops commented Nov 6, 2020

The current docker image is great to be used as a command line tool.

It would be good to have possibility to use the docker image as a base image.

FROM tlwt/sphinxneeds-docker

This is currently not possible in the way how the entry script runAfterBoot.sh is written.
For example, the creation of folders "/project/*" etc.

I guess with some minor changes to this script, it could be made reusable for the above mentioned usecase.

@tlwt
Copy link
Owner

tlwt commented Nov 12, 2020

Could you prepapre the changes as a pull-request? I gladly integratae them into the base image. I dont know when I find the time to do it.

@twodrops
Copy link
Contributor Author

@tlwt Sure, I can do that. I patched the script for now (see attached) so that I can use tlwt/sphinxneeds-docker as a base and use the modified runAfterBoot.sh script to generate the docs. I will have to invest some time to think on how the same script can be used as a start-up script and as a build script, without duplicating it.

In short, the workflow is to use tlwt/sphinxneeds-docker as a base and override ENTRYPOINT on start-up and use runAfterBoot.sh or build.sh from inside the container to generate docs.

build.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants