Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scalaz/Cats Disjunction to stdlib and vice versa #17

Open
yilinwei opened this issue Aug 15, 2016 · 2 comments
Open

Scalaz/Cats Disjunction to stdlib and vice versa #17

yilinwei opened this issue Aug 15, 2016 · 2 comments

Comments

@yilinwei
Copy link
Member

  • import cats._, cats.implicits._ should be changed to import scalaz._, Scalaz._
  • piecemeal imports should have alternatives
  • Xor.left/right should be changed to a disjunction and vice versa
  • patmat of disjunctions/Xor should change
  • in the case of scalaz, flatMap/map is non existent on the Xor?
@zainab-ali
Copy link
Contributor

How do you think this should cope with different cats / scalaz versions? cats.intances and cats.kernel were added in more recent versions, but older ones don't have them.

@yilinwei
Copy link
Member Author

Only the most recent should be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yilinwei @zainab-ali