Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split the title element from the seo/head snippet #112

Open
FlorianBoe opened this issue Oct 8, 2024 · 1 comment
Open

Split the title element from the seo/head snippet #112

FlorianBoe opened this issue Oct 8, 2024 · 1 comment
Labels
accepting prs 🧜‍♀️ Not to be implemented in the future; except if feature is provided in a PR type: enhancement ✨ Suggests an enhancement; improves the plugin
Milestone
2.0.0

Comments

@FlorianBoe
Copy link

First of all, thank you for this wonderful plugin!

Would it be useful to add a way to split the title element from the seo/head snippet?

For performance reasons, it makes sense to structure the elements in the head so that the SEO and meta tags are at the end. However, the title element should be integrated as early as possible.

<head>
  <meta charset |http-equiv| viewport />
  <title></title>
  <!-- preconnect -->
  <script src="" async></script>
  <!-- CSS that includes @import -->
  <!-- Synchronous JS -->
  <!-- Synchronous CSS -->
  <!-- preloads -->
  <script src="" defer></script>
  <!-- prefetch / prerender -->
  <!-- Everything else ('SEO' meta tags, icons, Open Graph, etc.) -->
</head>

More on this, for example, in this talk or on capo.js.
@tobimori tobimori added type: enhancement ✨ Suggests an enhancement; improves the plugin accepting prs 🧜‍♀️ Not to be implemented in the future; except if feature is provided in a PR labels Oct 8, 2024
@tobimori
Copy link
Owner

tobimori commented Oct 8, 2024

if anyone wants to implement this, I would make it a solution based on slots. if slots: true is passed to the snippet, it should output "priority" values, the slot, all other values. Priority could be specified here: https://github.com/tobimori/kirby-seo/blob/main/classes/Meta.php#L128 maybe?

@tobimori tobimori added this to the 2.0.0 milestone Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepting prs 🧜‍♀️ Not to be implemented in the future; except if feature is provided in a PR type: enhancement ✨ Suggests an enhancement; improves the plugin
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@FlorianBoe @tobimori