Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop the requirement of specifying an extractor #19

Closed
cyyynthia opened this issue Jan 12, 2023 · 1 comment · Fixed by #44
Closed

Drop the requirement of specifying an extractor #19

cyyynthia opened this issue Jan 12, 2023 · 1 comment · Fixed by #44
Assignees
@cyyynthia
Labels
enhancement New feature or request released

Comments

@cyyynthia
Copy link
Collaborator

cyyynthia commented Jan 12, 2023 •
edited
Loading

See: #16 (comment)

We can infer the SDK in use by checking which SDK is imported in the file.
@cyyynthia cyyynthia added the enhancement New feature or request label Jan 12, 2023
@cyyynthia cyyynthia self-assigned this Jan 12, 2023
@cyyynthia cyyynthia mentioned this issue Apr 24, 2023
Merged
2 tasks
cyyynthia added a commit that referenced this issue Apr 24, 2023
@cyyynthia
feat: use the appropriate extractor dynamically
2c4d424 
closes #19
cyyynthia added a commit that referenced this issue Apr 25, 2023
@cyyynthia
feat: svelte extractor (#44)
0657a36 
* feat: svelte extractor

* feat: use the appropriate extractor dynamically

closes #19

* fix: test comment-only file

* chore: massive speedup for e2e tests

* chore: build cli before e2e tests

* fix: update doc link

* chore: install eslint

* fix: consistent spacing

* chore: rename test properly
@github-actions
Copy link

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cyyynthia cyyynthia

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: svelte extractor tolgee/tolgee-cli
1 participant
@cyyynthia