Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable selected languages limit instead of hardcoding to max 10 #2907

Open
vlad-roid opened this issue Feb 12, 2025 · 5 comments
Open
Assignees
Labels
enhancement New feature or request for-superday Tolgee SuperDay is a step part hiring process when candidate work on real task

Comments

@vlad-roid
Copy link

vlad-roid commented Feb 12, 2025

Can this please be fixed so there is no hard limit or at least the limit is configurable? I want to be able to see and review ALL languages at once and don't care if it's slower to load. A "(de)select all" would be immensely helpful as well.
Right now reviewing 30 languages means clicking 10 check boxes one by one, then deselecting them, clicking the next 10 check boxes, deselecting them, clicking the last 10 check boxes. This is such a ridiculous waste of time and the limitation makes no sense from a user's perspective apart from making life more difficult

Originally posted by @vlad-roid in #1376 (comment)

@JanCizmar
Copy link
Contributor

Hey!

The issue with showing so many languages is not only about it's slow on your side, but also it possibly consumes a lot of resources on the side of our DBs system.

I know this is not optimal and we should optimize it. Sorry for the incovenience.

However, can you please elaborate what actually is your use case that you need to see all 30 languages at the same time?

Thanks!

@vlad-roid
Copy link
Author

Hi @JanCizmar sorry I should've made clear I'm referring to the self-hosted option! So having a configurable limit when self-hosting is reasonable as that won't touch "your DB".

Typical use case is adding a new key, bulk translating to all languages, then reviewing all translations at once which at the moment is not possible (requiring the tedious check box clicking).

@JanCizmar
Copy link
Contributor

Understood. But you cannot speak more than 10 languages? So what are you actually checking on the strings? Is it that they are filled?

@vlad-roid
Copy link
Author

vlad-roid commented Feb 19, 2025

That is true 😄 no only checking and fixing structure and malformed placeholders or HTML tags. Missing, additional or inadvertently modified punctuation marks, additional whitespace in front of and behind HTML tags (something Google translate loves to add, very annoying), whether some text stayed English (happens sometimes for uppercase), or very specific things like changing %% escaped percent sign to % in Chinese and Japanese and fixing whitespace in French to make it non-breakable. Those are just examples, there are many things a single person can review without knowing the language.

@JanCizmar JanCizmar self-assigned this Feb 19, 2025
@JanCizmar JanCizmar added enhancement New feature or request for-superday Tolgee SuperDay is a step part hiring process when candidate work on real task labels Feb 19, 2025
@JanCizmar
Copy link
Contributor

OK! That's a nice feedback. Thanks for it!

We are currently working on the QA checks feature, which should cover these cases. @ZuzanaOdstrcilova

In the same time, I am adding your requirement to add the configuration for max languages to the backlog.

@ZuzanaOdstrcilova ZuzanaOdstrcilova mentioned this issue Feb 19, 2025
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request for-superday Tolgee SuperDay is a step part hiring process when candidate work on real task
Projects
None yet
Development

No branches or pull requests

2 participants