Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon breaks CSS hot reloading #14

Open
mirague opened this issue Jul 7, 2017 · 2 comments
Open

Addon breaks CSS hot reloading #14

mirague opened this issue Jul 7, 2017 · 2 comments

Comments

@mirague
Copy link

mirague commented Jul 7, 2017

Anytime a change to a .scss file is made, the assets/tests.js is also modified, resulting in a full-page reload. Removing the addon restores the functioning of the hot reloading.

Observe this by running DEBUG="ember-cli:live-reload*" ember serve:

file changed styles/app.scss

styles/app.scss
  26:10  warning  Color 'red' should be written in its hexadecimal form #ff0000  no-color-keywords

✖ 1 problem (0 errors, 1 warning)


Build successful (464ms) – Serving on http://localhost:4200/
  ember-cli:live-reload: files %a [ 'assets/myApp.css', 'assets/tests.js' ] +6s



Slowest Nodes (totalTime => 5% )              | Total (avg)
----------------------------------------------+---------------------
SassCompiler (1)                              | 150ms
broccoli-persistent-filter:Autoprefixe... (1) | 55ms
SourceMapConcat: Concat: Vendor /asset... (1) | 36ms
Funnel: Addon JS (21)                         | 29ms (1 ms)

Any tips on how to prevent a reload?

@tomasbasham
Copy link
Owner

Hi. I tracked down what is causing this issue. It is a problem where the underlying broccoli plugin is generating tests even in a development environment, thus causing the change to assets/tests.js. I'll try to push a fix for this ASAP, but unfortunately there are no tips I can offer to prevent it in the meantime.

@tomasbasham
Copy link
Owner

tomasbasham commented Jul 27, 2017

For clarity. This is the line causing the issue. I think it should only be there when running the test suite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants