Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate keys in the config #332

Open
johnnovak opened this issue Jan 27, 2025 · 2 comments
Open

Duplicate keys in the config #332

johnnovak opened this issue Jan 27, 2025 · 2 comments

Comments

@johnnovak
Copy link

johnnovak commented Jan 27, 2025

I've just noticed the config can contain duplicate keys. E.g., this is what you get if you mount two directory hard drives:

filesystem2=rw,DH0:System:..\System-3.1,0
uaehf0=dir,rw,DH0:System:..\System-3.1,0
filesystem2=rw,DH1:Demo:"..\Demos\AGA\Little Nell (The Black Lotus, 2002)",-128
uaehf1=dir,rw,DH1:Demo:"..\Demos\AGA\Little Nell (The Black Lotus, 2002)",-128

This is a problem if you want to read the config into a hashmap for further processing. Not the end of the world, but then getting rid of duplicate keys would be so easy by putting an index after filesystem or filesystem2. Could you please get rid of duplicate keys? 😄

@tonioni
Copy link
Owner

tonioni commented Jan 27, 2025

filesystem2 entries are quite old backwards compatibility entries. You can manually delete them and config file should still work. Maybe it is time to not save them anymore. Not yet sure..

@johnnovak
Copy link
Author

johnnovak commented Jan 28, 2025

filesystem2 entries are quite old backwards compatibility entries. You can manually delete them and config file should still work. Maybe it is time to not save them anymore. Not yet sure..

Just tested it @tonioni and it's the other way around:

  • If I delete the filesystem2 entries and only leave the uaehf* entries, the hard drives tab is empty when loading the config.
  • If I keep the filesystem2 entries and delete uaehf*, the hard drives are shown correctly.

So it seems there's a bug. It would be good if filesystem2 was optional, I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants