Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML color codes in HEX format appear incorrect in OpenGL rendering #233

Open
HikeAndMap opened this issue Jan 15, 2025 · 2 comments
Open
Labels

Comments

@HikeAndMap
Copy link

I add a screenshot again first

image
On the left is the actual real true colour from the orthographic imagery
right of it you can see how I tagged it
right of that the html colour from https://htmlcolorcodes.com/

This is "close enough for me"

below how that looks on OSM2World
image

So clearly html colour coding isn't supported, or something else is missing (on my end or OSM2World's side?)

But I may just make a mistake in tagging here so please let me know if I do anything wrong

@HikeAndMap
Copy link
Author

HikeAndMap commented Jan 15, 2025

image

oh if I add building:colour it's working fine for the sides (building)
so it's really some rendering issue with the roof - again I may be doing something wrong, please let me know if I'm missing something.

Thank you so much

@tordanik tordanik changed the title feature request: support of html colour codes in HEX format HTML color codes in HEX format appear incorrect in OpenGL rendering Jan 16, 2025
@tordanik tordanik added the bug label Jan 16, 2025
@tordanik
Copy link
Owner

tordanik commented Jan 16, 2025

As you've discovered, HTML color codes in HEX format are already supported and work correctly for walls and some other features. But I can confirm that they don't appear to have much, if any, visible effect for tiled roofs for some reason.

Interestingly, this bug only seems to affect OpenGL rendering (e.g. the graphical interface) and not, say, models exported as glTF files. I suspect it's related to the use of clampedBaseColorFactor in JOGLTargetFixedFunction. Need to investigate further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants