Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tch to 0.18+ #2553

Closed
laggui opened this issue Nov 27, 2024 · 3 comments
Closed

Update tch to 0.18+ #2553

laggui opened this issue Nov 27, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@laggui
Copy link
Member

laggui commented Nov 27, 2024

Follow-up to #1765 which detailed windows issues for tch 0.16.

It seems both 0.17 and 0.18 also have issues, this time it seems to be a linking issue for CUDA.

So we're sticking to 0.15 for now.

LaurentMazare/tch-rs#904
LaurentMazare/tch-rs#907

@laggui laggui added the bug Something isn't working label Nov 27, 2024
@OmegaLambda1998
Copy link

OmegaLambda1998 commented Feb 19, 2025

Hi, sorry to necropost, but is there an accepted way of opting-in to a later version of tch? at the moment I'm just forking burn and replacing the tch dependency with:
tch = { version = "0.19.0", git = "https://github.com/LaurentMazare/tch-rs/" }
as this allows me to use ROCm 6.3 with pytorch 2.6 (nightly).
If there were a way to get similar behaviour without having to fork the entire repo to change one line, that would be awesome!

@laggui
Copy link
Member Author

laggui commented Feb 19, 2025

No prob, this issue is still open to keep track of the update. Looks like they actually released version 0.19 since but the linked issues are still open so would have to check.

is there an accepted way of opting-in to a later version of tch

Sadly I don't think there is a simpler way to achieve this given the cargo dependency resolution. Even if you try to override the tch dependency using a [patch] the versions won't match. Unless you fork tch instead and use this in your patch (which will require overwriting the version specifier to 0.15 in your fork), but that's more or less the same..

We could be more flexible in the version specification for tch (e.g., >=0.15,<0.20.0) but we would either 1) have to make sure that all versions are compatible (not always as easy, especially with how libtorch is being linked on different systems) or 2) let users specify at their own risk (not always a great user experience).

@laggui
Copy link
Member Author

laggui commented Feb 24, 2025

Closed with #2834

@laggui laggui closed this as completed Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants