Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update 20190831-newfeature.md #829

Open
JLKwong opened this issue Feb 22, 2021 · 1 comment
Open

update 20190831-newfeature.md #829

JLKwong opened this issue Feb 22, 2021 · 1 comment

Comments

@JLKwong
Copy link
Member

JLKwong commented Feb 22, 2021

Problem

This tutorial blog asks you to name the mock feature temperature, but there is a real command called temperature. If someone approves the PR from this practice, they could accidentally replace create a duplicate of the real temperature command.

Steps to reproduce the problem

If you follow the New Feature blog, you will find yourself either creating a duplicate temperature command or replace the original temperature command.

Screenshots

image

Proposed solution

Replace all names of the mock function from temperature to faketemp.

JLKwong added a commit to JLKwong/JLKwong.github.io that referenced this issue Feb 24, 2021
@Mia-XXXX
Copy link
Contributor

Mia-XXXX commented Apr 2, 2022

The issue title is confusing as it duplicated with your other issue. I suggest to have a better title to reflect the file and issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants