Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: frappe/insights
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: develop
Choose a base ref
...
head repository: tridz-dev/insights
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: develop
Choose a head ref
Able to merge. These branches can be automatically merged.
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Sep 3, 2024

  1. fix(ui): hide sidebar before being mounted

    @pu-raihan
    pu-raihan committed Sep 3, 2024
    Copy the full SHA
    09ea7f1 View commit details

  2. Merge branch 'frappe:develop' into develop

    @pu-raihan
    pu-raihan authored Sep 3, 2024
    Copy the full SHA
    283edd2 View commit details
Showing with 9 additions and 2 deletions.
  1. +9 −2 frontend/src/components/AppShell.vue
11 changes: 9 additions & 2 deletions frontend/src/components/AppShell.vue
View file
Original file line number Diff line number Diff line change
@@ -19,11 +19,18 @@ import Sidebar from '@/components/Sidebar.vue'
import SuspenseFallback from '@/components/SuspenseFallback'
import sessionStore from '@/stores/sessionStore'
import settingsStore from '@/stores/settingsStore'
import { computed, onMounted } from 'vue'
import { ref, onMounted, watch } from 'vue'
import { useRoute } from 'vue-router'
const session = sessionStore()
const route = useRoute()
const hideSidebar = computed(() => route.meta.hideSidebar || !session.isLoggedIn)
const hideSidebar = ref(true)
watch(
route,
(newRoute) => {
hideSidebar.value = newRoute.meta.hideSidebar || !session.isLoggedIn
},
{ immediate: true }
)
onMounted(() => session.isLoggedIn && settingsStore())
</script>