Neutral team order not respected in sidebar on TWW (and possibly other maps)

[doctored]

normal factions are displayed in turn order but neutrals all displayed last. start screen does respect ordering:

but sidebar does not:

would assume this also applies to other maps but have not tested.

[frigoref]

Summary: The tab Players shows the players in different sorting orders compared to the start screen (according to step order), e.g., on map total_world_war which seems to be due to code in PlayerOrderComparator.
The two comments here struck me as they seem to contradict each other:

1. A comparator for {@link GamePlayer} that sorts instances in game play order.
   (describing the purpose of the class matching the expectation of @doctored)
2. sort based on first step that isn't a bid related step.
   (which is actually implemented and causing the difference).

The Comparator is only used in method PlayerList.getSortedPlayers() which is used in the mentioned StatPanel (tab Players) and EconomyPanel.

It is unclear to me why such a difference would be needed and therefore I am asking for clarification from @DanVanAtta or @asvitkine.

[asvitkine]

I'm not sure the history of the difference, but I suspect it's not intended and making it consistent would be benefitial.

[doctored]

it changed in 2.7, cant fathom any logic behind making this only not work for neutrals

[doctored]

not sure if this helps but it seems whatever is breaking this happens when the game is first created. if i open a game saved prior to 2.7 the order is correct in the sidebar

[RenXFlo]

Hi, if it's possible i would like to take this issue.

[frigoref]

@RenXFlo go ahead. Happy coding!
Please try to reuse the same sorting code as basis.

[RenXFlo]

@RenXFlo go ahead. Happy coding! Please try to reuse the same sorting code as basis.

Is there any way of comunicating if im unsure about anything other than coments? Because I have few questions afther looking through classes and I just want to make sure I understand the issue properly without spaming the comment section.