Skip to content
This repository was archived by the owner on Mar 8, 2025. It is now read-only.

Style Guide / Contributing #189

Open
ryanolson opened this issue Feb 14, 2025 · 1 comment
Open

Style Guide / Contributing #189

ryanolson opened this issue Feb 14, 2025 · 1 comment

Comments

@ryanolson
Copy link
Contributor

Topics that have come up in MRs:

  • use of log vs. tracing for events
  • using inline {variable} vs "{}", variable in format

Let's form a list, define a policy and then apply that policy across the code.

          I just like typing `log`.  Feels right for what it's doing at that moment. 

Let's standardize on this in the style guide.

Originally posted by @ryanolson in #181 (comment)

@ryanolson ryanolson mentioned this issue Feb 14, 2025
20 tasks
@alec-flowers
Copy link
Contributor

alec-flowers commented Feb 18, 2025

To get rust logs in python in the wheel and through the c/rust API in vLLM I added the tracing-subscriber package.

This lets you do something like RUST_LOG=info python3 ... and will allow you to see the logging in rust as well as python. @ryanolson I noticed you also have something that allows you to do this with TRD_LOG. I think we should also standardize here as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants