Skip to content
This repository was archived by the owner on Mar 8, 2025. It is now read-only.

fix: remove all warnings from the kv router merge #213

Open
ryanolson opened this issue Feb 19, 2025 · 1 comment
Open

fix: remove all warnings from the kv router merge #213

ryanolson opened this issue Feb 19, 2025 · 1 comment
Assignees
Labels
good first issue Good for newcomers

Comments

@ryanolson
Copy link
Contributor

remove #[allow(dead_code)] from scheduler.rs and fix warnings.

          I put that in there to avoid all the warnings.  This was a quick fix which should have been caught by CI.  CI should enforce the build to complete without errors. This happened on the KV Router merge.  We should open a ticket and resolve those in a separate PR.

Originally posted by @ryanolson in #201 (comment)

@rmccorm4
Copy link
Contributor

warning: field `scheduler` is never read
  --> triton-llm/src/kv_router.rs:48:5
   |
41 | pub struct KvRouter {
   |            -------- field in this struct
...
48 |     scheduler: KvScheduler,
   |     ^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

warning: variants `NoRoutes` and `SchedulerOffline` are never constructed
  --> triton-llm/src/kv_router/scheduler.rs:33:5
   |
28 | pub enum KvSchedulerError {
   |          ---------------- variants in this enum
...
33 |     NoRoutes,
   |     ^^^^^^^^
...
42 |     SchedulerOffline,
   |     ^^^^^^^^^^^^^^^^
   |
   = note: `KvSchedulerError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis

warning: field `request_tx` is never read
  --> triton-llm/src/kv_router/scheduler.rs:90:5
   |
89 | pub struct KvScheduler {
   |            ----------- field in this struct
90 |     request_tx: tokio::sync::mpsc::Sender<SchedulingRequest>,
   |     ^^^^^^^^^^

warning: method `schedule` is never used
   --> triton-llm/src/kv_router/scheduler.rs:178:18
    |
93  | impl KvScheduler {
    | ---------------- method in this implementation
...
178 |     pub async fn schedule(
    |                  ^^^^^^^^

warning: `triton-llm` (lib) generated 4 warnings
warning: `triton-llm` (lib test) generated 4 warnings (4 duplicates)
    Finished `test` profile [unoptimized + debuginfo] target(s) in 17.05s
     Running unittests src/lib.rs (target/debug/deps/triton_llm_capi-1af7f785a632c7b4)

@rmccorm4 rmccorm4 added the good first issue Good for newcomers label Feb 20, 2025
@grahamking grahamking self-assigned this Feb 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants