From 6094a19571f431e276d526dc5e73a2fb0057279d Mon Sep 17 00:00:00 2001 From: corey Date: Wed, 22 Jan 2025 13:12:33 -0800 Subject: [PATCH] only fetch done feedback results --- src/core/trulens/core/database/sqlalchemy.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/core/trulens/core/database/sqlalchemy.py b/src/core/trulens/core/database/sqlalchemy.py index d0923a731..d25186b16 100644 --- a/src/core/trulens/core/database/sqlalchemy.py +++ b/src/core/trulens/core/database/sqlalchemy.py @@ -802,7 +802,11 @@ def get_records_and_feedback( self.orm.AppDefinition.app_name == app_name ) - stmt = stmt.options(joinedload(self.orm.Record.feedback_results)) + # Only load feedback results where the status column is "done". + stmt = stmt.join(self.orm.Record.feedback_results).filter( + self.orm.FeedbackResult.status + == feedback_schema.FeedbackResultStatus.DONE.value + ) stmt = stmt.options(joinedload(self.orm.Record.app)) # NOTE(piotrm): The joinedload here makes it so that the # feedback_results and app definitions get loaded eagerly instead if lazily when