This repository has been archived by the owner on Apr 11, 2023. It is now read-only.
feat: setup UI endpoint to serve the UI #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
- Coverage 87.70% 87.08% -0.62%
==========================================
Files 6 6
Lines 431 457 +26
==========================================
+ Hits 378 398 +20
- Misses 34 38 +4
- Partials 19 21 +2
Continue to review full report at Codecov.
|
pkg/restapi/operation/operations.go
Outdated
| c.presDefsLock.Lock() | ||
| defer c.presDefsLock.Unlock() | ||
|
|
||
| c.userProfileRequest[handle] = r |
There was a problem hiding this comment.
Shouldn't we set this in database instead of local map ?
There was a problem hiding this comment.
@llorllale @aholovko what you guys recommend ?
There was a problem hiding this comment.
@talwinder50 should use transient store
talwinder50
changed the title
talwinder50
changed the title
talwinder50
changed the title
talwinder50
force-pushed
the
issue-39
branch
2 times, most recently
from
36b18b8 to
ca867db
Compare
llorllale
suggested changes
Jul 29, 2020
talwinder50
force-pushed
the
issue-39
branch
3 times, most recently
from
c0bd95d to
37ef6e0
Compare
talwinder50
force-pushed
the
issue-39
branch
2 times, most recently
from
a67a122 to
4d4af26
Compare
talwinder50
force-pushed
the
issue-39
branch
2 times, most recently
from
85ddeaf to
bdc8354
Compare
rolsonquadras
approved these changes
Jul 30, 2020
llorllale
reviewed
Jul 30, 2020
| @@ -143,6 +149,7 @@ type authRestParameters struct { | |||
| tlsParams *tlsParams | |||
| oidcParams *oidcParams | |||
| bootstrapParams *bootstrapParams | |||
| staticFiles string | |||
There was a problem hiding this comment.
staticFiles is not being assigned a value
talwinder50
force-pushed
the
issue-39
branch
2 times, most recently
from
599194c to
05ec7b6
Compare
llorllale
approved these changes
Jul 30, 2020
closes trustbloc#39 Signed-off-by: talwinder.kaur <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #39
Signed-off-by: talwinder.kaur [email protected]