Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check motion magnification #10

Open
nicolas-tardieu opened this issue Sep 24, 2020 · 8 comments
Open

Check motion magnification #10

nicolas-tardieu opened this issue Sep 24, 2020 · 8 comments

Comments

@nicolas-tardieu
Copy link

Hi all,

First, thank you for the work done since I am deeply interested in the potential of this algorithm and mainly in motion magnification.
I managed to compile the code but I am still strugling to be sure it works OK.

Would you have an example video and dedicated settings to check it works fine on my computer?

Thanks,
Nicolas

@tschnz
Copy link
Owner

tschnz commented Sep 24, 2020

Hey, I can verify that magnification with Riesz Pyramids does NOT work as expected due to a bug.

@nicolas-tardieu
Copy link
Author

Thanks for the information Jens.
Do you plan to fix the bug or you do not have time for that at the moment?

@nincube8
Copy link

nincube8 commented Sep 25, 2020 via email

@nincube8
Copy link

nincube8 commented Sep 25, 2020 via email

@nicolas-tardieu
Copy link
Author

Perhaps I was not clear enough : I did compile the code and I can run it on a video.
My question is : can you provide me with a test video so that I can be sure my installation is fine as far as motion magnification is concerned (usually, there is a target "test" in a Makefile that runs nonregression checks).

@nincube8
Copy link

nincube8 commented Sep 25, 2020 via email

@MirekJan
Copy link

MirekJan commented Sep 25, 2020 via email

@tschnz
Copy link
Owner

tschnz commented Nov 17, 2024

This was my bachelor thesis and I won't find (unpaid) time to add tests and check for validity. The code makes me shiver already but I try to keep it compileable. The code is not correct in terms of all framerates and wavelength, especially with varying FPS on live streams but it serves as a good enough proof-of-concept and to showcase that live amplification is possible. I would not use this code in a business context at all (I tried once). It's error prone and best case needs a shader based rewrite.

I leave this issue open as warning to other users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants