Bankable CCButtons with Latched Increment Selector Switch #397

tmanning47 · 2021-02-13T18:46:16Z

tmanning47
Feb 13, 2021

I've been working on a guitar pedalboard using 15 latching footswitches, and I'm a bit stumped as to getting bank switching to work. A0 is the pin for the bank switch

I also have a feeling that CCbuttons may not be the best class to use.

I saw a similar question in regards to latched increment selectors on the discussion board but decided I didn't want to piggyback off that thead.

Any help with this is greatly appreciated!

Current Code: (CCButtons work, bank increment button does nothing)

#include <Control_Surface.h> // Include the Control Surface library

//DEBUG
USBDebugMIDI_Interface midi = 115200; //Comment out USBMIDI_Interface midi
 

// Instantiate a MIDI over USB interface. (COMMENT OUT IF DEBUGGING)
//USBMIDI_Interface midi;

Bank<3> bank1(1,0);
//   │        └───── number of tracks per bank , starting bank
//   └───────────── number of banks
 
// Instantiate a Bank selector to control which one of the 3 Banks is active. -not working-
IncrementSelector<3> selector = {
  bank1, // Bank to manage
  A0,    // push button pin
};

// Wrapping around means that if you're in Bank 4 and you press the increment 
// button, you wrap back around to Bank 1. Similarly, if you're in Bank 1 and
// you press the decrement button, you wrap back around to Bank 4.
// The alternative to Wrap::Wrap is Wrap::Clamp. In that case, pressing the 
// increment button when you're in Bank 4 won't do anything, you'll stay in 
// Bank 4. If you're in Bank 1 and press the decrement button, you'll stay in 
// Bank 1.


Bankable::CCButtons<14> buttons = {  
  {bank1, BankType::CHANGE_CHANNEL},
  {0,1,2,3,4,5,6,7,8,9,10,11,12,13}, // button pins
  {MIDI_CC::General_Purpose_Controller_1, CHANNEL_1}, // address of first button
  {1, 0}, // interval between addresses (1 controller number, 0 channels , cable)
  {0x7F, 0x7F},  //Sends ON Message Only {0x7F, 0x7F}             Sends On Off {0x7F, 0x00}
};

// CC Values 1=16 2=17 3=18 4=19 5=20 6=21 7=22 8=23 9=24 10=25 11=26 12=27 13=28 14=29 15=30
// Pins      0    1    2    3    4    5    6    7    8    9     10    11    12    13    A0

void setup() {
  Control_Surface.begin(); // Initialize Control Surface  
}

void loop() {
  Control_Surface.loop(); // Update the Control Surface
}

tttapa · 2021-02-20T15:12:13Z

tttapa
Feb 20, 2021
Maintainer

Start by trying the Button example for pin A0. If that doesn't work, there's something wrong with the wiring of your switch.

I'll see if I can add a selector for latched switches.

7 replies

tmanning47 Mar 5, 2021
Author

Sorry about that, updated the code in the last reply, and I'm using an Arduino Leonardo (Model #: A000057)

tttapa Mar 5, 2021
Maintainer

Are any of your buttons pressed while you're trying to change the bank? Bankable::CCButtons preserves the bank for as long as some buttons are pressed. Otherwise it would send release events on different channels than the corresponding press events. The delay probably doesn't help either.

tmanning47 Mar 5, 2021
Author

Its very likely, they are mechanically latching which I use to only send ON messages to trigger toggles in my DAWs. I don't have any way to physically indicate if the switch is down or up though..

tttapa Mar 5, 2021
Maintainer

In that case it's probably easiest to use a custom CCButtons-like implementation. It shouldn't be too hard to strip out the code that locks the bank if any buttons are pressed. Here's the relevant file: https://tttapa.github.io/Control-Surface-doc/Doxygen/d9/df7/Bankable_2Abstract_2MIDIButtons_8hpp_source.html
You can also find some examples explaining how to create custom MIDI elements.

tmanning47 Mar 5, 2021
Author

Wow that worked! Thank you!

Working code for 15 CCButtons + Bank Change Potentiometer:

 #include <Encoder.h>
#include <Control_Surface.h> // Include the Control Surface library
 
 BEGIN_CS_NAMESPACE
  
 namespace Bankable {
  
 template <class BankAddress, class Sender, uint8_t NumButtons>
 class MIDIButtons1 : public MIDIOutputElement {
   protected:
     MIDIButtons1(BankAddress bankAddress,
                 const Array<AH::Button, NumButtons> &buttons,
                 const RelativeMIDIAddress &incrementAddress,
                 const Sender &sender)
         : address(bankAddress), buttons{buttons},
           incrementAddress(incrementAddress), sender{sender} {}
  
   public:
     void begin() final override {
         for (auto &button : buttons)
             button.begin();
     }
     void update() final override {
         RelativeMIDIAddress offset = {0, 0, 0};
         for (auto &button : buttons) {
             AH::Button::State state = button.update();
             if (state == AH::Button::Falling) {
                 //if (!activeButtons)
                     //address.lock(); // Don't allow changing of the bank setting
                 MIDIAddress sendAddress = address.getActiveAddress() + offset;
                 sender.sendOn(sendAddress);
                 activeButtons++;
             } else if (state == AH::Button::Rising) {
                 MIDIAddress sendAddress = address.getActiveAddress() + offset;
                 sender.sendOff(sendAddress);
                 activeButtons--;
                 //if (!activeButtons)
                     //address.unlock();
             }
             offset += incrementAddress;
         }
     }
  
 #ifdef AH_INDIVIDUAL_BUTTON_INVERT
     void invert() {
         for (auto &button : buttons)
             button.invert();
     }
 #endif
  
     AH::Button::State getButtonState(size_t index) const {
         return buttons[index].getState();
     }
  
   private:
     BankAddress address;
     Array<AH::Button, NumButtons> buttons;
     RelativeMIDIAddress incrementAddress;
     uint8_t activeButtons = 0;
  
   public:
     Sender sender;
 };
  
 } // namespace Bankable
  
 END_CS_NAMESPACE

 BEGIN_CS_NAMESPACE
  
 namespace Bankable {
  
 template <uint8_t NumButtons>
 class CCButtons1
     : public MIDIButtons1<SingleAddress, DigitalCCSender, NumButtons> {
   public:
     CCButtons1(OutputBankConfig<> config,
               const Array<AH::Button, NumButtons> &buttons,
               MIDIAddress baseAddress, RelativeMIDIAddress incrementAddress,
               const DigitalCCSender &sender = {})
         : MIDIButtons1<SingleAddress, DigitalCCSender, NumButtons>(
               {config, baseAddress}, buttons, incrementAddress, sender) {}
 };
  
 } // namespace Bankable
  
 END_CS_NAMESPACE
 

#include <AH/Hardware/Button.hpp>

USBMIDI_Interface midi;     //-----COMMENT OUT IF DEBUGGING-----
                                                                    
//USBDebugMIDI_Interface midi = 115200; //Uncomment to Debug    -- 115200 baud --  DEBUG

Bank<6> bank1(1,0);
//   │        └───── number of tracks per bank , starting bank
//   └───────────── number of banks

//using namespace MIDI_Notes; 
Bankable::CCButtons1<15> buttons = { 
  {bank1, BankType::CHANGE_CHANNEL},
  {0,1,2,3,4,5,6,7,8,9,10,11,12,13,A0}, // button pins
  {MIDI_CC::General_Purpose_Controller_1, CHANNEL_1}, // address of first button
  {1, 0}, // interval between addresses (1 controller number, 0 channels , cable)
  {0x7F, 0x7F},  //Sends ON Message Only {0x7F, 0x7F}             Sends On Off {0x7F, 0x00}
};

//CCButton button15 (A0, {MIDI_CC::General_Purpose_Controller_1, CHANNEL_4},{0x7F, 0x7F});
//Button button15 {A0}; // Button to test if changing the address in the loop() works

// CC Values 1=16 2=17 3=18 4=19 5=20 6=21 7=22 8=23 9=24 10=25 11=26 12=27 13=28 14=29 15=30
// Pins      0    1    2    3    4    5    6    7    8    9     10    11    12    13    A0



int potentiometer_pin = A5;  
int potentiometer_value = 0;  
int pulse_value = 0;



void setup() {
  Control_Surface.begin(); // Initialize Control Surface
}

void loop() {
  Control_Surface.loop(); // Update the Control Surface
  
  potentiometer_value = analogRead(potentiometer_pin);  
  pulse_value = potentiometer_value / 250; 
  //bank1.select(pulse_value);
  //Serial.println(pulse_value);
  //delay(1000);

  switch(pulse_value) {
  case 4:
    //Serial.println("Bank 1");
    bank1.select(0);
    break;
  case 3:
    //Serial.println("Bank 2");
    bank1.select(1);
    break;
  case 2:
    //Serial.println("Bank 3");
    bank1.select(2);
    break;
  case 1:
    //Serial.println("Bank 4");
    bank1.select(3);
    break;
  case 0:
    //Serial.println("Bank 5");
    bank1.select(4);
    break;
  default:
    //Serial.println("Default");
    break;
  }
}

tmanning47 · 2023-08-15T13:08:35Z

tmanning47
Aug 15, 2023
Author

15 buttons, 1 potentiometer for bank control; buttons send Midi CC + Joystick button commands simultaneously. Keeping my code updated here, having this this backed up has saved my bacon a few times now:

#include <Encoder.h>
#include <Control_Surface.h> // Include the Control Surface library
 
 BEGIN_CS_NAMESPACE
  
 namespace Bankable {
  
 template <class BankAddress, class Sender, uint8_t NumButtons>
 class MIDIButtons1 : public MIDIOutputElement {
   protected:
     MIDIButtons1(BankAddress bankAddress,
                 const Array<AH::Button, NumButtons> &buttons,
                 const RelativeMIDIAddress &incrementAddress,
                 const Sender &sender)
         : address(bankAddress), buttons{buttons},
           incrementAddress(incrementAddress), sender{sender} {}
  
   public:
     void begin() final override {
         for (auto &button : buttons)
             button.begin();
     }
     void update() final override {
         RelativeMIDIAddress offset = {0, 0, 0};
         for (auto &button : buttons) {
             AH::Button::State state = button.update();
             if (state == AH::Button::Falling) {
                 //if (!activeButtons)
                     //address.lock(); // Don't allow changing of the bank setting
                 MIDIAddress sendAddress = address.getActiveAddress() + offset;
                 sender.sendOn(sendAddress);
                 activeButtons++;
             } else if (state == AH::Button::Rising) {
                 MIDIAddress sendAddress = address.getActiveAddress() + offset;
                 sender.sendOff(sendAddress);
                 activeButtons--;
                 //if (!activeButtons)
                     //address.unlock();
             }
             offset += incrementAddress;
         }
     }
  
 #ifdef AH_INDIVIDUAL_BUTTON_INVERT
     void invert() {
         for (auto &button : buttons)
             button.invert();
     }
 #endif
  
     AH::Button::State getButtonState(size_t index) const {
         return buttons[index].getState();
     }
  
   private:
     BankAddress address;
     Array<AH::Button, NumButtons> buttons;
     RelativeMIDIAddress incrementAddress;
     uint8_t activeButtons = 0;
  
   public:
     Sender sender;
 };
  
 } // namespace Bankable
  
 END_CS_NAMESPACE

 BEGIN_CS_NAMESPACE
  
 namespace Bankable {
  
 template <uint8_t NumButtons>
 class CCButtons1
     : public MIDIButtons1<SingleAddress, DigitalCCSender, NumButtons> {
   public:
     CCButtons1(OutputBankConfig<> config,
               const Array<AH::Button, NumButtons> &buttons,
               MIDIAddress baseAddress, RelativeMIDIAddress incrementAddress,
               const DigitalCCSender &sender = {})
         : MIDIButtons1<SingleAddress, DigitalCCSender, NumButtons>(
               {config, baseAddress}, buttons, incrementAddress, sender) {}
 };
  
 } // namespace Bankable
  
 END_CS_NAMESPACE
 

#include <AH/Hardware/Button.hpp>

USBMIDI_Interface midi;     //-----COMMENT OUT IF DEBUGGING-----
                                                                    
//USBDebugMIDI_Interface midi = 115200; //Uncomment to Debug    -- 115200 baud --  DEBUG

Bank<6> bank1(1,0);
//   │        └───── number of tracks per bank , starting bank
//   └───────────── number of banks

//using namespace MIDI_Notes; 
Bankable::CCButtons1<15> buttons = { 
  {bank1, BankType::CHANGE_CHANNEL},
  {0,1,2,3,4,5,6,7,8,9,10,11,12,13,A0}, // button pins
  {MIDI_CC::General_Purpose_Controller_1, CHANNEL_1}, // address of first button
  {1, 0}, // interval between addresses (1 controller number, 0 channels , cable)
  {0x7F, 0x7F},  //Sends ON Message Only {0x7F, 0x7F}             Sends On Off {0x7F, 0x00}
};

//CCButton button15 (A0, {MIDI_CC::General_Purpose_Controller_1, CHANNEL_4},{0x7F, 0x7F});
//Button button15 {A0}; // Button to test if changing the address in the loop() works

// CC Values 1=16 2=17 3=18 4=19 5=20 6=21 7=22 8=23 9=24 10=25 11=26 12=27 13=28 14=29 15=30
// Pins      0    1    2    3    4    5    6    7    8    9     10    11    12    13    A0



int potentiometer_pin = A5;  
int potentiometer_value = 0;  
int pulse_value = 0;



void setup() {
  Control_Surface.begin(); // Initialize Control Surface
}

void loop() {
  Control_Surface.loop(); // Update the Control Surface
  
  potentiometer_value = analogRead(potentiometer_pin);  
  pulse_value = potentiometer_value / 250; 
  //bank1.select(pulse_value);
  //Serial.println(pulse_value);
  //delay(1000);

  switch(pulse_value) {
  case 4:
    //Serial.println("Bank 1");
    bank1.select(0);
    break;
  case 3:
    //Serial.println("Bank 2");
    bank1.select(1);
    break;
  case 2:
    //Serial.println("Bank 3");
    bank1.select(2);
    break;
  case 1:
    //Serial.println("Bank 4");
    bank1.select(3);
    break;
  case 0:
    //Serial.println("Bank 5");
    bank1.select(4);
    break;
  default:
    //Serial.println("Default");
    break;
  }
}

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bankable CCButtons with Latched Increment Selector Switch #397

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Replies: 2 comments 7 replies

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{editor}}'s edit

{{editor}}'s edit

Select a reply

Bankable CCButtons with Latched Increment Selector Switch #397

tmanning47 Feb 13, 2021

Replies: 2 comments · 7 replies

tttapa Feb 20, 2021 Maintainer

tmanning47 Mar 5, 2021 Author

tttapa Mar 5, 2021 Maintainer

tmanning47 Mar 5, 2021 Author

tttapa Mar 5, 2021 Maintainer

tmanning47 Mar 5, 2021 Author

tmanning47 Aug 15, 2023 Author

tmanning47
Feb 13, 2021

Replies: 2 comments 7 replies

tttapa
Feb 20, 2021
Maintainer

tmanning47 Mar 5, 2021
Author

tttapa Mar 5, 2021
Maintainer

tmanning47 Mar 5, 2021
Author

tttapa Mar 5, 2021
Maintainer

tmanning47 Mar 5, 2021
Author

tmanning47
Aug 15, 2023
Author