Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in git repo url of target clones new repo #568

Open
ar13pit opened this issue Apr 7, 2021 · 6 comments
Open

Changes in git repo url of target clones new repo #568

ar13pit opened this issue Apr 7, 2021 · 6 comments

Comments

@ar13pit
Copy link
Contributor

ar13pit commented Apr 7, 2021

@MatthijsBurgh @Timple Is cloning the repo again the desired behavior? Or should we just be moving the repo directory to the new location, as the current behavior leaves the older copy in place for the user to manually remove it

@MatthijsBurgh
Copy link
Member

I think this indeed undesired.

People could have local changes etc. If these are just gone, that is wrong.

@Timple
Copy link
Member

Timple commented Apr 8, 2021

The new URL might be vastly different. So you 'cant' simply move it then...

@MatthijsBurgh
Copy link
Member

@Timple we don't need to cover all cases, just the most common ones. I think the most common ones are repos being forked or going back from fork to original repo.

Do you have other cases in mind?

@Timple
Copy link
Member

Timple commented Apr 8, 2021

I don't have a strong opinion about this by the way, so I'm good with all outcomes.

You can also simply give a warning in case of local changes and don't touch it.

@ar13pit
Copy link
Contributor Author

ar13pit commented Apr 8, 2021

One case that I encountered is renaming of the repo in the URL

@MatthijsBurgh
Copy link
Member

Both in my case and the case of @ar13pit we moving the repo is a safe option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants