Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoD BWL update broke the unitframes module #200

Open
emsimpson92 opened this issue Sep 24, 2024 · 9 comments
Open

SoD BWL update broke the unitframes module #200

emsimpson92 opened this issue Sep 24, 2024 · 9 comments

Comments

@emsimpson92
Copy link

image

I pulled the latest dev version but the unit frames module seems to be broken with the new update. When I open the game menu (esc) there is also no "tukui" option in there, so I'm unable to make any other adjustments.

@emsimpson92
Copy link
Author

emsimpson92 commented Sep 24, 2024

/tukui config still works. As far as I can tell other modules work fine

Edit: Nameplates and party frame are broken too

@emsimpson92
Copy link
Author

I can provide the script errors if it helps

@JerichoR
Copy link
Contributor

Well yes, without we have no clue what the issue is. A Lua error in player frame likely and it stops processing there.

@JerichoR
Copy link
Contributor

Looking at it, you don't have Atonement buff on targets for disc healing yet, so the atonement element isn't needed at all for classic. But would still be interesting what broke it instead just never finding the buff and doing nothing.

@emsimpson92
Copy link
Author

@JerichoR

Message: ...face/AddOns/Tukui/Modules/Miscellaneous/DropDown.lua:89: attempt to index local 'Menu' (a nil value)
Time: Tue Sep 24 17:54:31 2024
Count: 1
Stack: ...face/AddOns/Tukui/Modules/Miscellaneous/DropDown.lua:89: attempt to index local 'Menu' (a nil value)
[string "@Interface/AddOns/Tukui/Modules/Miscellaneous/DropDown.lua"]:89: in function Enable' [string "@Interface/AddOns/Tukui/Modules/Miscellaneous/Core.lua"]:9: in function Enable'
[string "@Interface/AddOns/Tukui/Core/Loading.lua"]:262: in function <Interface/AddOns/Tukui/Core/Loading.lua:241>

Locals: self = Frame {
ChatMenus =

{
}
}
Menu = nil
(for index) = 1
(for limit) = 4
(for step) = 1
i = 1
(*temporary) =
{
ERR_OUT_OF_CHI = "Not enough chi"
DH_HAVOC_CORE_ABILITY_2 = "Strong melee attack that consumes Fury. If it critical strikes, some Fury is refunded."
SettingsSliderOptionsMixin =
{
}
UNIT_NAMES_COMBATLOG_TOOLTIP = "Color unit names."
LE_GAME_ERR_CHAT_RAID_RESTRICTED_TRIAL = 798
SPELL_FAILED_CUSTOM_ERROR_71 = "This partygoer wants to dance with you."
LE_GAME_ERR_PET_SPELL_TARGETS_DEAD = 413
ERROR_CLUB_TICKET_COUNT_AT_MAX_COMMUNITY = "Can't create any more invite links for this group."
ERR_TRADE_EQUIPPED_BAG = "You can't trade equipped bags."
PVP_RANK_6_1 = "Corporal"
MultiBarLeftButton7 = MultiBarLeftButton7 {
}
OPTION_TOOLTIP_SHOW_MULTIBAR4 = "Toggles an additional optional actionbar on the right side of the screen."
LE_GAME_ERR_INVALID_FOLLOW_PVP_COMBAT = 365
MerchantItem1AltCurrencyFrameItem1Text = MerchantItem1AltCurrencyFrameItem1Text {
}
DetailsWindowOptionsBarTextEditorEntryNumberLines = DetailsWindowOptionsBarTextEditorEntryNumberLines {
}
OPTION_TOOLTIP_ACTION_BUTTON_USE_KEY_DOWN = "Action button keybinds will respond on key down, rather than on key up."
BINDING_NAME_NAMEPLATES = "Show Enemy Name Plates"
CHAT_HEADER_SUFFIX = ": "
MultiBarBottomRightButton8Shine5 = MultiBarBottomRightButton8Shine5 {
}
MAIL_LETTER_TOOLTIP = "Click to make a permanent
copy of this letter."
DUNGEON_FLOOR_UPPERBLACKROCKSPIRE3 = "Hall of Blackhand"
CHAT_CONFIG_OTHER_COMBAT =
{
}
BN_UNABLE_TO_RESOLVE_NAME = "Unable to whisper '%s'. Blizzard services may be unavailable."
CinematicFrameRaidBossEmoteFrame = CinematicFrameRaidBossEmoteFrame {
}
CompactRaidFrameManagerDisplayFrameHiddenModeToggleTopRight = CompactRaidFrameManagerDisplayFrameHiddenModeToggleTopRight {
}
LE_GAME_ERR_ONLY_ONE_QUIVER = 33
SpellButton6Cooldown = SpellButton6Cooldown {
}
DetailsBreakdownWindowTabFrameSummary6633PhaseScrollContainerHeaderLineHeaderIndex4 = DetailsBreakdownWindowTabFrameSummary6633PhaseScrollContainerHeaderLineHeaderIndex4 {
}
LOSS_OF_CONTROL_DISPLAY_FEAR = "Feared"
ChatFrame4MinimizeButton = ChatFrame4MinimizeButton {
}
StanceButton4FlyoutArrow = StanceButton4FlyoutArrow {
}
MultiBarRightButton7Shine9 = MultiBarRightButton7Shine9 {
}
BankFrameItem17SearchOverlay = BankFrameItem17SearchOverlay {
}
AUCTIONATOR_L_DEFAULT_LIST_HEADER = "Default Shopping List"
DMG_LCD = "DMG"
ACTION_SPELL_MISSED_POSSESSIVE = "1"
SLASH_STOPATTACK1 = "/stopattack"
ContainerFrame4Item16Cooldown = ContainerFrame4Item16Cooldown {
}
MINIMAP_TRACKING_TRAINER_CLASS = "Class Trainer"
SLASH_DISMOUNT2 = "/dismount"
DUNGEON_FLOOR_DRAGONBLIGHTCHROMIESCENARIO2 = "Andorhal"
TokenFrameContainerButton15Stripe = TokenFrameContainerButton15Stripe {
}
StanceButton8Shine15 = StanceButton8Shine15 {
}
L =
{
}
EMOTE69_CMD1 = "/nosepick"
WowTokenRedemptionFrameBg = WowTokenRedemptionFrameBg {
}
DetailsBreakdownWindowTabFrameSummary6633SpellScrollContainerSpellScrollSpellBarButton11FontString12 = DetailsBreakdownWindowTabFrameSummary6633SpellScrollContainerSpellScrollSpellBarButton11FontString12 {
}
SHIELD_BLOCK_TEMPLATE = "%d Block"
rend801NWBWorldMap = rend801NWBWorldMap {
}
LAG_TOLERANCE = "Lag Tolerance"
GuildControlPopupFrame = GuildControlPopupFrame {
}
ARENA_CASUAL = "Skirmish"
SendStationeryBackgroundRight

@emsimpson92
Copy link
Author

This seems to be the only error I'm getting from tukui. The update broke a lot of other addons as well

@tukz
Copy link
Contributor

tukz commented Sep 25, 2024

Update, it was fixed earlier today

@emsimpson92
Copy link
Author

Confirmed. Just pulled the dev branch and we're good to go. Thanks for the quick turnaround on this!

@JerichoR
Copy link
Contributor

Ah, well. Wasn't about the Atonement changes but a different one. Still good we checked and got it solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants