Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DROP TABLE support #894

Open
penberg opened this issue Feb 5, 2025 · 3 comments · May be fixed by #1022
Open

DROP TABLE support #894

penberg opened this issue Feb 5, 2025 · 3 comments · May be fixed by #1022
Labels
core enhancement New feature or request help wanted Extra attention is needed
Milestone
0.1.0

Comments

@penberg
Copy link
Collaborator

penberg commented Feb 5, 2025

No description provided.

@penberg penberg added core enhancement New feature or request labels Feb 5, 2025
@penberg penberg added this to the 0.1.0 milestone Feb 5, 2025
@penberg penberg added the help wanted Extra attention is needed label Feb 5, 2025
@krishvishal
Copy link
Contributor

free_page functionality required by DROP TABLE is implemented in PR #785

limbo/core/storage/pager.rs

Line 441 in a01a994

pub fn free_page(&self, page: Option<PageRef>, page_id: usize) -> Result<()> {

redixhumayun added a commit to redixhumayun/limbo that referenced this issue Feb 5, 2025
@redixhumayun
drop table: addresses issue tursodatabase#894 which requires DROP TAB…
e021681 
…LE to be implemented

this is the initial commit is for the implementation of DROP TABLE. It adds support for the DROP TABLE instruction and adds a DropBTree instruction. It also implements the btree_drop method in btree.rs which makes use of free_page method which will be implemented via PR tursodatabase#785
@redixhumayun redixhumayun mentioned this issue Feb 5, 2025
Open
@redixhumayun
Copy link
Contributor

I've started a draft PR for this issue here - #897

Would appreciate any eyes on it. Just want to make sure I'm heading in roughly the right direction.

redixhumayun added a commit to redixhumayun/limbo that referenced this issue Feb 8, 2025
@redixhumayun
drop table: addresses issue tursodatabase#894 which requires DROP TAB…
3952fd5 
…LE to be implemented

this is the initial commit is for the implementation of DROP TABLE. It adds support for the DROP TABLE instruction and adds a DropBTree instruction. It also implements the btree_drop method in btree.rs which makes use of free_page method which will be implemented via PR tursodatabase#785
redixhumayun added a commit to redixhumayun/limbo that referenced this issue Feb 15, 2025
@redixhumayun
drop table: addresses issue tursodatabase#894 which requires DROP TAB…
bd5e658 
…LE to be implemented

this is the initial commit is for the implementation of DROP TABLE. It adds support for the DROP TABLE instruction and adds a DropBTree instruction. It also implements the btree_drop method in btree.rs which makes use of free_page method which will be implemented via PR tursodatabase#785
redixhumayun added a commit to redixhumayun/limbo that referenced this issue Feb 16, 2025
@redixhumayun
drop table: addresses issue tursodatabase#894 which requires DROP TAB…
a64e0c0 
…LE to be implemented

this is the initial commit is for the implementation of DROP TABLE. It adds support for the DROP TABLE instruction and adds a DropBTree instruction. It also implements the btree_drop method in btree.rs which makes use of free_page method which will be implemented via PR tursodatabase#785
@someshkoli
Copy link

someshkoli commented Feb 16, 2025 •
edited
Loading

Would appreciate any eyes on it. Just want to make sure I'm heading in roughly the right direction.

I started working on this around same time and saw this open 💀 regardless, ive drafted initial bits in #1022
i'll probably close it, yours look more complete as of now 🚀

@someshkoli someshkoli linked a pull request Feb 16, 2025 that will close this issue
Draft
redixhumayun added a commit to redixhumayun/limbo that referenced this issue Feb 18, 2025
@redixhumayun
drop table: addresses issue tursodatabase#894 which requires DROP TAB…
be91f76 
…LE to be implemented

this is the initial commit is for the implementation of DROP TABLE. It adds support for the DROP TABLE instruction and adds a DropBTree instruction. It also implements the btree_drop method in btree.rs which makes use of free_page method which will be implemented via PR tursodatabase#785
redixhumayun added a commit to redixhumayun/limbo that referenced this issue Feb 19, 2025
@redixhumayun
drop table: addresses issue tursodatabase#894 which requires DROP TAB…
76e2d98 
…LE to be implemented

this is the initial commit is for the implementation of DROP TABLE. It adds support for the DROP TABLE instruction and adds a DropBTree instruction. It also implements the btree_drop method in btree.rs which makes use of free_page method which will be implemented via PR tursodatabase#785
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

draft: drop table implementation someshkoli/limbo
4 participants
@penberg @krishvishal @redixhumayun @someshkoli