Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload against a deferred resource does not work without options.uploadLengthDeferred #182

Open
mmatuska opened this issue Feb 21, 2020 · 2 comments · May be fixed by #744
Open

Upload against a deferred resource does not work without options.uploadLengthDeferred #182

mmatuska opened this issue Feb 21, 2020 · 2 comments · May be fixed by #744
Labels
bug

Comments

@mmatuska
Copy link

Describe the bug
If a remote resource is deferred and the server reports the "Upload-Defer-Length: 1" header,
tus-js-client is not able to upload against the resource without options.uploadLengthDeferred.
The protocol does not enfoce this. Upload-Length can be sent with the very next PATCH request.

To Reproduce
Create a deferred resource.

curl -v -X POST -H 'Tus-Resumable: 1.0.0' -H 'Upload-Defer-Length: 1' https://master.tus.io/files

Try to upload against the resource without options.uploadLengthDeferred
Error: "tus: invalid or missing length value"

Expected behavior
It should be possible to upload against the deferred resource without options.uploadLengthDeferred

Setup details
@mmatuska mmatuska added the bug label Feb 21, 2020
mmatuska added a commit to mmatuska/tus-js-client that referenced this issue Feb 21, 2020
@mmatuska
Always allow uploading Upload-Defer-Length resources (tus#182)
46d4124
mmatuska added a commit to mmatuska/tus-js-client that referenced this issue Feb 21, 2020
@mmatuska
Always allow uploading Upload-Defer-Length resources (tus#182)
d8b61f9
mmatuska added a commit to mmatuska/tus-js-client that referenced this issue Feb 21, 2020
@mmatuska
Always allow uploading Upload-Defer-Length resources (tus#182)
1bdc5fe
@Acconut Acconut changed the title Upload against a deffered resource does not work without options.uploadLengthDeferred Upload against a deferred resource does not work without options.uploadLengthDeferred Feb 22, 2020
@Acconut
Copy link
Member

Acconut commented Feb 22, 2020

Thank you for reporting this! I agree with you that this should not happen. Seeing that you already worked on a patch, would you be willing to submit a PR for this?

@Vija02 Vija02 linked a pull request Jan 13, 2025 that will close this issue
Open
@Acconut
Copy link
Member

Acconut commented Jan 13, 2025

Related PR: #744

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set Upload-Length when appropriate Vija02/tus-js-client
2 participants
@mmatuska @Acconut