DetailedError type definitions are missing possible nulls

[nh2]

The types say all fields in DetailedError are guaranteed to be peresent:

tus-js-client/lib/index.d.ts

Lines 123 to 127 in 4ff243c

	export class DetailedError extends Error {
	originalRequest: HttpRequest;
	originalResponse: HttpResponse;
	causingError: Error;
	}

But they are null sometimes. This caused a runtime crash in my app.

I think this would be a great idea, as humans just aren't good at tracking what can be null and what cannot:

• Generate TypeScript definitions from source #296

Cause

tus-js-client/lib/error.js

Lines 1 to 2 in 4ff243c

	class DetailedError extends Error {
	constructor (message, causingErr = null, req = null, res = null) {

• causingError can be null:
  

  tus-js-client/lib/upload.js

  Line 124 in 4ff243c

  throw new DetailedError('tus: unexpected response while terminating upload', null, req, res)

• originalResponse can be null:
  

  tus-js-client/lib/upload.js

  Lines 126 to 128 in 4ff243c

  	if (!(err instanceof DetailedError)) {
  	err = new DetailedError('tus: failed to terminate upload', err, req, null)
  	}

[Acconut]

You are correct, thank you for reporting! Would you be able to submit a PR to fix the current type definitions? Getting the automatically generated is a nice improvement but will probably take some time to achieve.

[nh2]

PR in #582.