When using filestore as the storage backend, why are chunk files not closed during the merging phase?

[nervtech]

Hi,

I was reviewing the code and noticed that in the file merge process, the file opened with os.Open is not explicitly closed.

tusd/pkg/filestore/filestore.go

Lines 242 to 253 in d69efe0

	for _, partialUpload := range uploads {
	fileUpload := partialUpload.(*fileUpload)
	src, err := os.Open(fileUpload.binPath)
	if err != nil {
	return err
	}
	if _, err := io.Copy(file, src); err != nil {
	return err
	}
	}

From my understanding, not closing the file could lead to resource leaks, especially with file descriptors.

Is there a specific reason why src.Close() is omitted here?

[Acconut]

Thank you for pointing this out! You are right that this function is missing calls to src.Close. This seems to be a mistake in my eyes and not serving any purpose. Would you be interested in opening a PR to fix this?