Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input_frames_used returned by src_process may be less than the number of input frames #7

Open
hcab14 opened this issue Dec 7, 2020 · 5 comments

Comments

@hcab14
Copy link

hcab14 commented Dec 7, 2020

(error, input_frames_used, output_frames_gen) = src_process(
self._state, input_data, output_data, ratio, end_of_input)

Currently input_frames_used is ignored.

This problem prevents python-samplerate to work correctly if the resampling ratio does not divide the block size provided to Resampler.process.

PR #6 is an attempt to fix this issue.

@tuxu: what would be the timeline for making a new release?

@tuxu
Copy link
Owner

tuxu commented Dec 8, 2020

Thanks for the PR, @hcab14! We can upload a new release to PyPI just after your changes are reviewed and merged into master.

@hcab14
Copy link
Author

hcab14 commented Dec 8, 2020

Thanks a lot for your response!

Somehow this problem was not caught by the tests, so it'd be good to have a test case for that. I can start thinking about that.

BTW: the documentation for python-samplerate is very good.

@hcab14
Copy link
Author

hcab14 commented Dec 18, 2020

Thanks for the PR, @hcab14! We can upload a new release to PyPI just after your changes are reviewed and merged into master.

@tuxu: did you have a look at the changes?

The motivation for these changes comes from here where currently only a few resampling ratios are supported due to this issue.

@hcab14
Copy link
Author

hcab14 commented Apr 29, 2021

ping

@tuxu
Copy link
Owner

tuxu commented Apr 30, 2021

Sorry, I was busy with a lot of other things. Hope to get back to you very soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants