Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate API key #504

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Validate API key #504

merged 4 commits into from
Feb 22, 2024

Conversation

dremin
Copy link
Contributor

@dremin dremin commented Feb 22, 2024

Summary

Before we deploy anything, we need to make sure that we are on a Flex account, and that the provided API key and secret are for the same account as the provided account SID. This can help prevent accidental deployments to the wrong account when setting up an environment.

Checklist

  • Tested changes end to end
  • Updated documentation
  • Requested one or more reviewers

@djayanna
Copy link

djayanna commented Feb 22, 2024

@dremin quick question - so if the validate-flex-account job fails (process exists with non-zero), the jobs that depends/needs this step (e.g. perform-initial-serverless-release) will not run, correct?

@dremin
Copy link
Contributor Author

dremin commented Feb 22, 2024

@dremin quick question - so if the validate-flex-account job fails (process exists with non-zero), the jobs that depends/needs this step (e.g. perform-initial-serverless-release) will not run, correct?

Yup! Here is an example run that shows what happens: https://github.com/twilio-professional-services/flex-project-template/actions/runs/7997394623/job/21841779364

@dremin dremin merged commit a4970db into main Feb 22, 2024
12 of 13 checks passed
@dremin dremin deleted the validate-api-key branch February 22, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants