Fix custom-hold-music with native XWT participants #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dremin
requested review from
Romanti-Ezer,
trogers-twilio,
aestellwag and
swillcox-twilio
|
0 ESLint error(s) and 0 ESLint warning(s) found in pull request changed files. ✅ No issues found! |
Romanti-Ezer
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Great job again @dremin! 🎉
Test Results below
- Issue observed - Using an account with native warm transfer enabled (Johnson Flex) and in the
mainbranch
The custom hold music is not being played to the invited participant
Issue.observed.-.Native.XMT.participant.not.hearing.custom.hold.music.20240417.mov
- Fix validated ✅ - Using an account with native warm transfer enabled (Johnson Flex) and in the
custom-hold-native-xwtbranch
The custom hold music is correctly being played to the invited participant
Fix.custom-hold-music.with.native.XWT.participants.-.Test.20240417.mov
- Regression test ✅ - using an account without the native warm transfer, but using the conference feature from the template - in the
custom-hold-native-xwtbranch
The custom hold music is correctly being played to the invited participant
Custom.Hold.Music.Regression.Testing.-.Conference.feature.20240417.mov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using native external warm transfer, the HoldParticipant action's holdMusicUrl payload property is ignored. Override the handling for these participants to allow custom-hold-music to take effect. See SEFLEX-3875 for more details.
Checklist