Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action to select CRM tab #654

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Add action to select CRM tab #654

merged 3 commits into from
Dec 9, 2024

Conversation

dremin
Copy link
Contributor

@dremin dremin commented Oct 11, 2024

Summary

Now features can programmatically select a specific tab in the CRM container.

Also made tabs that don’t target a task work better, and adjusted logic so that adding tabs dynamically is possible.

Checklist

  • Tested changes end to end
  • Updated documentation
  • Requested one or more reviewers

dremin added 2 commits October 9, 2024 15:45
Also make tabs that don’t target a task work better
Copy link

0 ESLint error(s) and 0 ESLint warning(s) found in pull request changed files.
✅ No issues found!

Copy link

@trogers-twilio trogers-twilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Clever use of tabState and the custom action "SelectCRMContainerTab" listeners to handle the tab change.

@dremin dremin merged commit df13066 into main Dec 9, 2024
11 checks passed
@dremin dremin deleted the select-crm-tab branch December 9, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants