Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IRequestValidator to more easily support injection (and mocking) of RequestValidator #655

Open
mducharm opened this issue Nov 17, 2022 · 1 comment
Open

Add IRequestValidator to more easily support injection (and mocking) of RequestValidator #655

mducharm opened this issue Nov 17, 2022 · 1 comment
Labels
status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap

Comments

@mducharm
Copy link

Issue Summary

The example for validating requests suggests that you disable validation in your tests, but I think it'd be nice to simply register an IRequestValidator in your app's service collection, allowing you to easily mock the validator when testing.
@AsabuHere AsabuHere added type: community enhancement feature request not on Twilio's roadmap status: help wanted requesting help from the community and removed type: community enhancement feature request not on Twilio's roadmap status: help wanted requesting help from the community labels Nov 23, 2022
@AsabuHere
Copy link
Contributor

This issue has been added to our internal backlog to be prioritised. Pull requests and +1s on the issue summary will help it move up the backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mducharm @AsabuHere