Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the queue_name argument for DefaultExchangePublisher optional #105

Open
2 tasks
roback opened this issue Feb 12, 2024 · 0 comments
Open
2 tasks

Make the queue_name argument for DefaultExchangePublisher optional #105

roback opened this issue Feb 12, 2024 · 0 comments

Comments

@roback
Copy link
Member

roback commented Feb 12, 2024

In #104 I made it possible for the #publish method to override publishing options. That makes it possible to set the routing key per message. Even though I only documented this for the TopicExchangePublisher in that PR (since that is where we were going to use it), this works for the DefaultExchangePublisher too.

The DefaultExchangePublisher however, has a mandatory queue_name argument, which doesn't make sense in that case. We should make that argument optional.

This is something that would be nice to have with RabbitMQ RPC (using direct reply), as we would need to set different routing keys per message then. Until we have fixed this, we could perhaps just set queue_name to an empty string, since it won't be used then.

Todo

  • Make the queue_name argument optional
  • Document that the DefaultExchangePublisher supports options in the #publish method, as I only documented this for the TopicExchangePublisher (both of those classes includes the Publisher module, so their #publish methods have the same functionality)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant