Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JRuby support? #19

Open
dentarg opened this issue Oct 23, 2015 · 10 comments
Open

JRuby support? #19

dentarg opened this issue Oct 23, 2015 · 10 comments
Labels

Comments

@dentarg
Copy link
Contributor

dentarg commented Oct 23, 2015

We're about to introduce JRuby in a project, and wouldn't it be cool if we could just use Twingly::AMQP over there? ;-)

Also, when we have JRuby in place, I think there will be more projects that what to "hop on the train".

@jage
Copy link
Contributor

jage commented Oct 23, 2015

I've heard that https://github.com/ruby-amqp/march_hare is worth looking at when running JRuby. Bunny might work if we limit to JRuby 9000 though (https://github.com/ruby-amqp/bunny#supported-ruby-versions).

@dentarg
Copy link
Contributor Author

dentarg commented Oct 23, 2015

I was thinking that Twingly::AMQP could be smart, on JRuby, use March Hare, on CRuby, use Bunny. But maybe that's too much work, not possible, or just a bad idea?

@jage
Copy link
Contributor

jage commented Oct 23, 2015

I was thinking that Twingly::AMQP could be smart, on JRuby, use March Hare, on CRuby, use Bunny. But maybe that's too much work, not possible, or just a bad idea?

I think that's what is required and probably a good idea. We might need to tweak our abstraction a bit to make everything fit beneath it, but we should at least look at it. We should probably wait until our first JRuby project has proven itself worthy.

@dentarg
Copy link
Contributor Author

dentarg commented Oct 23, 2015

We should probably wait until our first JRuby project has proven itself worthy.

Yes, that sounds reasonable.

@dentarg
Copy link
Contributor Author

dentarg commented Oct 26, 2015

Re: Bunny and JRuby

18 days ago, ruby-amqp/bunny#356 (comment)

Thank you but JRuby is no longer supported.

@walro walro modified the milestone: Sprint41 Nov 11, 2016
@twingly-mob
Copy link
Member

We should start with using march_hare in a project and then extract that code if it fits here.

@jage
Copy link
Contributor

jage commented Nov 22, 2016

Might be interesting to read for inspiration: https://github.com/travis-ci/travis-amqp/tree/master/lib/travis/amqp

@jage jage removed this from the Sprint41 milestone Dec 5, 2016
@roback
Copy link
Member

roback commented Feb 9, 2018

18 days ago, ruby-amqp/bunny#356 (comment)

Thank you but JRuby is no longer supported.

Bunny now works with JRuby: ruby-amqp/bunny#529, though march_hare is still probably a better alternative.

@walro
Copy link
Contributor

walro commented May 4, 2018

Bunny now works with JRuby: ruby-amqp/bunny#529, though march_hare is still probably a better alternative.

We need to require at least 2.7.3 in our gemspec.

@walro
Copy link
Contributor

walro commented Nov 3, 2020

I tried publishing, using twingly-amqp under JRuby. Seems to work.

I think we could do the things necessary to at least support JRuby "on the paper". It ought to be just to require some minimum version of Bunny.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants