You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A label may contain zero to 63 characters. The null label, of length zero, is reserved for the root zone. The full domain name may not exceed the length of 253 characters in its textual representation.[20] In the internal binary representation of the DNS the maximum length requires 255 octets of storage, as it also stores the length of the name.[3]
We're seeing Ruby barfing on certain URLs that have very long host portions.
If I get things correctly this is where the limit is set (defaults to 1024 unless the environment says something else):
https://github.com/ruby/ruby/blob/b753929806d0e42cdfde3f1a8dcdbf678f937e44/ext/socket/socket.c#L897-L903
NI_MAXHOST
is set to 1025 in Bionic: http://manpages.ubuntu.com/manpages/bionic/man3/getnameinfo.3.html (check notes)So 1024 ought to be fine for most of our use-cases
The text was updated successfully, but these errors were encountered: