Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document examples of URL normalization with a table #96

Open
jage opened this issue Sep 15, 2016 · 2 comments
Open

Document examples of URL normalization with a table #96

jage opened this issue Sep 15, 2016 · 2 comments

Comments

@jage
Copy link
Contributor

jage commented Sep 15, 2016

The focus of the table would be to show the potential difference between a normalized and a non-normalized URL.

Method Non-normalized Normalized
.host räksmörgås.макдональдс.рф xn--rksmrgs-5wao1o.xn--80aalb1aicli8a5i.xn--p1ai

Original discussion in https://github.com/twingly/twingly-url/pull/90/files#r78955259

@dentarg
Copy link
Collaborator

dentarg commented Sep 15, 2016

I think it's kinda good that they are above/below each other, that's useful when you compare.

url.host                      # => "räksmörgås.макдональдс.рф"
url.normalized.host           # => "xn--rksmrgs-5wao1o.xn--80aalb1aicli8a5i.xn--p1ai"

Using a table I think we risk that a long string could be line broken (eh, is that how you say it? :))?

@walro
Copy link
Contributor

walro commented Sep 15, 2016

we risk that a long string could be line broken (eh, is that how you say it? :))?

hmm, maybe "wrapping", a long string would wrap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants