Skip to content
This repository has been archived by the owner on Dec 7, 2022. It is now read-only.

Plugin fails to load when there is an error in ranks.xml #826

Open
ghost opened this issue Aug 7, 2015 · 10 comments
Open

Plugin fails to load when there is an error in ranks.xml #826

ghost opened this issue Aug 7, 2015 · 10 comments
Assignees
Labels

Comments

@ghost
Copy link

ghost commented Aug 7, 2015

http://pastebin.com/9r8vskDg

@ElliottWhyman
Copy link
Collaborator

Please give us the full stack trace

@connorjayr
Copy link
Collaborator

Please also give us your ranks.xml file, found in plugins/Cardinal

@ghost
Copy link
Author

ghost commented Aug 7, 2015

@iEli2tyree011 can an error in the rank.xml cause the plugin to not load?

@ghost
Copy link
Author

ghost commented Aug 7, 2015

apparently it can

@ghost ghost closed this as completed Aug 7, 2015
@twizmwazin twizmwazin changed the title latest cardinal version wont load Plugin fails to load when there is an error in ranks.xml Aug 8, 2015
@twizmwazin
Copy link
Owner

Let's keep this open, we can have the plugin use default ranks if the config file is invalid

@twizmwazin twizmwazin reopened this Aug 8, 2015
@Pablete1234
Copy link
Collaborator

@twizmwazin if there's an invalid ranks file it should use default, but keep the other one so it can be fixed, and tell the error in console (and maybe warn op's when they join)

@twizmwazin
Copy link
Owner

@Pablete1234 That is what I planned on having, although rather than having a chat message just spam the console on startup

@Pablete1234
Copy link
Collaborator

@twizmwazin if you have a hosted server, you often don't look at the console, and someone kinda non-experienced trying to setup a rank system may be like "why is it not working!?!?!?" but a chat message sent to op's when the join "This server has an unvalid ranks.xml file" would be enough, and maybe also for the rotation file

@twizmwazin
Copy link
Owner

I'd rather just use the console. If someone is having an issue, it is expected they check the console for any errors.

@angelortizau
Copy link
Contributor

When theres an error on my version, theres no crashes, just loads the default ranks

@twizmwazin twizmwazin added the bug label Sep 8, 2015
@twizmwazin twizmwazin self-assigned this Sep 8, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants