Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crates.io as a distribution channel #17

Open
adpthegreat opened this issue Feb 8, 2025 · 2 comments
Open

Add crates.io as a distribution channel #17

adpthegreat opened this issue Feb 8, 2025 · 2 comments

Comments

@adpthegreat
Copy link

So I installed the surfpool-cli from crates.io and I get this error while building , the home-brew works fine btw

error[E0061]: this function takes 2 arguments but 1 argument was supplied
  --> /Users/username/.cargo/registry/src/index.crates.io-6f17d22bba15001f/surfpool-cli-0.1.2/src/cli/simnet/mod.rs:14:26
   |
14 |             let future = start_simnet(simnet_events_tx);
   |                          ^^^^^^^^^^^^------------------ argument #2 of type `crossbeam_channel::channel::Sender<SimnetEvent>` is missing
   |
note: expected `&SurfpoolConfig`, found `Sender<_>`
  --> /Users/username.cargo/registry/src/index.crates.io-6f17d22bba15001f/surfpool-cli-0.1.2/src/cli/simnet/mod.rs:14:39
   |
14 |             let future = start_simnet(simnet_events_tx);
   |                                       ^^^^^^^^^^^^^^^^
   = note: expected reference `&SurfpoolConfig`
                 found struct `std::sync::mpsc::Sender<_>`
note: function defined here
  --> /Users/userna/.cargo/registry/src/index.crates.io-6f17d22bba15001f/surfpool-core-0.1.4/src/lib.rs:24:14
   |
24 | pub async fn start_simnet(
   |              ^^^^^^^^^^^^
help: provide the argument
   |
14 |             let future = start_simnet(/* &SurfpoolConfig */, /* crossbeam_channel::channel::Sender<SimnetEvent> */);
   |                                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

error[E0004]: non-exhaustive patterns: `SimnetEvent::Ready`, `SimnetEvent::Aborted(_)` and `SimnetEvent::Shutdown` not covered
  --> /Users/username/.cargo/registry/src/index.crates.io-6f17d22bba15001f/surfpool-cli-0.1.2/src/cli/simnet/mod.rs:38:15
   |
38 |         match event {
   |               ^^^^^ patterns `SimnetEvent::Ready`, `SimnetEvent::Aborted(_)` and `SimnetEvent::Shutdown` not covered
   |
note: `SimnetEvent` defined here
  --> /Users/username/.cargo/registry/src/index.crates.io-6f17d22bba15001f/surfpool-core-0.1.4/src/simnet/mod.rs:35:1
   |
35 | pub enum SimnetEvent {
   | ^^^^^^^^^^^^^^^^^^^^
36 |     Ready,
   |     ----- not covered
37 |     Aborted(String),
   |     ------- not covered
38 |     Shutdown,
   |     -------- not covered
   = note: the matched value is of type `SimnetEvent`
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern, a match arm with multiple or-patterns as shown, or multiple match arms
   |
73 ~             SimnetEvent::BlockHashExpired => {},
74 +             SimnetEvent::Ready | SimnetEvent::Aborted(_) | SimnetEvent::Shutdown => todo!()
   |

error[E0004]: non-exhaustive patterns: `SimnetEvent::Ready`, `SimnetEvent::Aborted(_)` and `SimnetEvent::Shutdown` not covered
   --> /Users/username/.cargo/registry/src/index.crates.io-6f17d22bba15001f/surfpool-cli-0.1.2/src/tui/simnet.rs:160:19
    |
160 |             match event {
    |                   ^^^^^ patterns `SimnetEvent::Ready`, `SimnetEvent::Aborted(_)` and `SimnetEvent::Shutdown` not covered
    |
note: `SimnetEvent` defined here
   --> /Users/username/.cargo/registry/src/index.crates.io-6f17d22bba15001f/surfpool-core-0.1.4/src/simnet/mod.rs:35:1
    |
35  | pub enum SimnetEvent {
    | ^^^^^^^^^^^^^^^^^^^^
36  |     Ready,
    |     ----- not covered
37  |     Aborted(String),
    |     ------- not covered
38  |     Shutdown,
    |     -------- not covered
    = note: the matched value is of type `SimnetEvent`
help: ensure that all possible cases are being handled by adding a match arm with a wildcard pattern, a match arm with multiple or-patterns as shown, or multiple match arms
    |
210 ~                 SimnetEvent::BlockHashExpired => {},
211 +                 SimnetEvent::Ready | SimnetEvent::Aborted(_) | SimnetEvent::Shutdown => todo!()
    |

Some errors have detailed explanations: E0004, E0061.
For more information about an error, try `rustc --explain E0004`.
error: could not compile `surfpool-cli` (bin "surfpool") due to 3 previous errors
error: failed to compile `surfpool-cli v0.1.2`, intermediate artifacts can be found at `/var/folders/cp/ky5vzkfx11974m0hyhzgh29w0000gn/T/cargo-installtL2UmI`.
@adpthegreat adpthegreat changed the title Surfpool-cli does not build Surfpool-cli crates package does not build Feb 8, 2025
@lgalabru lgalabru changed the title Surfpool-cli crates package does not build Add Publish to crates.io to the CI Feb 8, 2025
@lgalabru
Copy link
Member

lgalabru commented Feb 8, 2025

Thanks, @adpthegreat! Our current CI isn’t publishing to crates.io. We’ll add this distribution to our CI, but we prioritized pre-built binaries via Homebrew and Snap since these channels are faster and more reliable for developers—they don’t require pulling dependencies, compiling, etc.

@lgalabru lgalabru changed the title Add Publish to crates.io to the CI Add crates.io as a distribution channel Feb 8, 2025
@adpthegreat
Copy link
Author

Alright thanks for the feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants