Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trait inheritance probabilities correctness #8

Closed
tylercamp opened this issue May 6, 2024 · 2 comments
Closed

Trait inheritance probabilities correctness #8

tylercamp opened this issue May 6, 2024 · 2 comments
Labels
help wanted Community feedback is needed to resolve

Comments

@tylercamp
Copy link
Owner

tylercamp commented May 6, 2024

Pal Calc relies on trait inheritance probabilities derived by /u/mgxts to estimate how long it will take for a given result, which affects the final "optimal" path displayed.

The pseudocode provided by this source, and some of the raw probabilities they derived, were used as the basis of the overall probability calculations in the BreedingSolver.

The current implementation gives results that seem right, but I'm not 100% sure that it's correct. Is any part of this calculation incorrect or inaccurate?

(This issue is just for correctness with respect to the currently known trait inheritance calculation. Updates for changes to the underlying calculation in new Palworld versions in a separate issue #7 )

@tylercamp tylercamp added the help wanted Community feedback is needed to resolve label May 6, 2024
@tylercamp
Copy link
Owner Author

Note - misc. review in the IV solver PR discovered a few inaccuracies/mistakes

c817d94
6b2f88b
a52c2f4
dc98f2f

@tylercamp
Copy link
Owner Author

Closing this now that there are unit tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Community feedback is needed to resolve
Projects
None yet
Development

No branches or pull requests

1 participant