Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoding of encoded pipe appears to be causing issues with multiple families with specific weights #438

Open
cam424 opened this issue Oct 2, 2020 · 0 comments

Comments

@cam424
Copy link

cam424 commented Oct 2, 2020

I'm specifically utilizing Nuxt's webfontloader module; however I believe the issue is being caused by the code here.

My original ticket is here.:
Url I expect:
https://fonts.googleapis.com/css?family=Lato:400,700|Frank+Ruhl+Libre:400,700

What I'm getting:
https://fonts.googleapis.com/css?family=Lato:400,700%7CFrank+Ruhl+Libre:400,700

What's happening:
This result is loading in the fonts, however the weights aren't available for styling my ui. Not sure if there's something with my configuration or if this is a bug.
...

It appears that the encoding for the pipe is hardcoded in this file, on line 65. I'm wondering if this is what's causing the issue.

Also, why is this hardcoded and not utilizing encodeURI()?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant