From 4d7e651429486646d3cc107178e7a5f027d7e368 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B8rn=20Madsen?= Date: Fri, 16 Mar 2018 20:40:42 -0400 Subject: [PATCH 1/4] Update to cats 1.1.0 --- build.sbt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.sbt b/build.sbt index 196d3ed395..c6ce7b5596 100644 --- a/build.sbt +++ b/build.sbt @@ -25,7 +25,7 @@ startYear in ThisBuild := Some(2017) val CompileTime = config("CompileTime").hide -val CatsVersion = "1.0.1" +val CatsVersion = "1.1.0" val SimulacrumVersion = "0.11.0" val ScalaTestVersion = "3.0.4" From fdf3a9b7f7944758dcc90a2a6369a7338a9958fe Mon Sep 17 00:00:00 2001 From: Victor Osolovskiy Date: Wed, 21 Mar 2018 23:35:10 +0300 Subject: [PATCH 2/4] Fix scaladoc --- core/shared/src/main/scala/cats/effect/Effect.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/shared/src/main/scala/cats/effect/Effect.scala b/core/shared/src/main/scala/cats/effect/Effect.scala index 1161ee85b8..852de9952b 100644 --- a/core/shared/src/main/scala/cats/effect/Effect.scala +++ b/core/shared/src/main/scala/cats/effect/Effect.scala @@ -59,7 +59,7 @@ trait Effect[F[_]] extends Async[F] { object Effect { /** - * [[Effect]] instance built for `cats.data.WriterT` values initialized + * [[Effect]] instance built for `cats.data.EitherT` values initialized * with any `F` data type that also implements `Effect`. */ implicit def catsEitherTEffect[F[_]: Effect]: Effect[EitherT[F, Throwable, ?]] = From 745365d8bf5f7352116d35a4aacf5eea1ef301d5 Mon Sep 17 00:00:00 2001 From: "Ross A. Baker" Date: Sun, 15 Apr 2018 20:31:11 -0400 Subject: [PATCH 3/4] IO.runAsync should report errors in its handler --- core/shared/src/main/scala/cats/effect/IO.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/shared/src/main/scala/cats/effect/IO.scala b/core/shared/src/main/scala/cats/effect/IO.scala index f9a2135869..0f5986d5b1 100644 --- a/core/shared/src/main/scala/cats/effect/IO.scala +++ b/core/shared/src/main/scala/cats/effect/IO.scala @@ -172,7 +172,7 @@ sealed abstract class IO[+A] extends internals.IOBinaryCompat[A] { * token that can be used to send a cancel signal */ final def runAsync(cb: Either[Throwable, A] => IO[Unit]): IO[Unit] = IO { - unsafeRunAsync(cb.andThen(_.unsafeRunAsync(_ => ()))) + unsafeRunAsync(cb.andThen(_.unsafeRunAsync(Callback.report))) } /** From 26485a078ab4819e8f4582b65ec85a4b42e61a6d Mon Sep 17 00:00:00 2001 From: "Ross A. Baker" Date: Tue, 17 Apr 2018 08:40:13 -0400 Subject: [PATCH 4/4] Correct IO.runAsync scaladoc --- core/shared/src/main/scala/cats/effect/IO.scala | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/core/shared/src/main/scala/cats/effect/IO.scala b/core/shared/src/main/scala/cats/effect/IO.scala index 0f5986d5b1..5aa180296c 100644 --- a/core/shared/src/main/scala/cats/effect/IO.scala +++ b/core/shared/src/main/scala/cats/effect/IO.scala @@ -160,7 +160,10 @@ sealed abstract class IO[+A] extends internals.IOBinaryCompat[A] { * // Sample * val source = IO.shift *> IO(1) * // Describes execution - * val start = source.runAsync + * val start = source.runAsync { + * case Left(e) => IO(e.printStackTrace()) + * case Right(_) => IO.unit + * } * // Safe, because it does not block for the source to finish * start.unsafeRunSync * }}}