Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] 5 unsupported features in the yaml2kotlin generator #854

Closed
jmfayard opened this issue May 30, 2023 · 1 comment
Closed

[Bug] 5 unsupported features in the yaml2kotlin generator #854

jmfayard opened this issue May 30, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@jmfayard
Copy link
Contributor

jmfayard commented May 30, 2023 •
edited
Loading

Action

To test the yaml2kotlin generator (previously script-generator)
I have a samples directory of 33 complete YAML workflows

  • I have generated the corresponding Kotlin workflows
  • I have executed them
  • I have compared the genreated YAML with the original one using https://www.yamldiff.com/

Expected

Ideally 100% of the feature should be supported

Actual

28 workflows just worked.

5 workflows had one unsupported feature each.

File Feature
DeployEnvironments.yml jobs > environment
E2eTests.yml jobs > timeout-minutes
Integration05.yml continue-on-error: true
Integration09.yml: jobs: job: if
NodeDeploy.yml: JamesIves/github-pages-deploy-action@releases/v3
@jmfayard jmfayard added the bug Something isn't working label May 30, 2023
@jmfayard jmfayard changed the title [Bug] 4 unsupported features in the yaml2kotlin generator [Bug] 5 unsupported features in the yaml2kotlin generator May 30, 2023
@jmfayard
Copy link
Contributor Author

moved to the new repo
typesafegithub/yaml2kotlin#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jmfayard