Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: IsUUID docs is outdated #2523

Open
4strodev opened this issue Aug 27, 2024 · 3 comments
Open

fix: IsUUID docs is outdated #2523

4strodev opened this issue Aug 27, 2024 · 3 comments
Labels
type: fix Issues describing a broken feature.

Comments

@4strodev
Copy link

Description

Internally it uses validator library and validator supports newer uuid versions. To avoid confusion, docs should be updated.

Expected behavior

Docs show that max supported uuid is v5.

Actual behavior

It actually supports uuid till v8

@4strodev 4strodev added status: needs triage Issues which needs to be reproduced to be verified report. type: fix Issues describing a broken feature. labels Aug 27, 2024
@braaar braaar removed the status: needs triage Issues which needs to be reproduced to be verified report. label Sep 6, 2024
@braaar
Copy link
Member

braaar commented Sep 6, 2024

PR welcome!

@4strodev
Copy link
Author

4strodev commented Sep 6, 2024

I will try to make a PR as soon as possible!. But from my experience in another repos I prefer to first make an issue and if the maintainers allow me then make a PR.

@4strodev
Copy link
Author

4strodev commented Sep 6, 2024

After checking the dependencies on package.json and the releases of validatorjs. The support of uuid v8 is on master right now on validatorjs. The latest release 13.12. Has support for v1 to v7. Maybe an update could be a good idea. The problem here is that after updating the packages, the test suite fails. I could try to fix the bug. But I prefer to have green light before starting to make the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: fix Issues describing a broken feature.
Development

No branches or pull requests

2 participants