Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate return type of createExpressServer with more narrow type #1244

Open
TokugawaTakeshi opened this issue Oct 1, 2023 · 1 comment
Open

Annotate return type of createExpressServer with more narrow type #1244

TokugawaTakeshi opened this issue Oct 1, 2023 · 1 comment
Labels
flag: needs discussion Issues which needs discussion before implementation. type: feature Issues related to new features.

Comments

@TokugawaTakeshi
Copy link

Description

Currently, createExpressServer function returns any.
It is the serious type safety crack for the application.

Proposed solution

I suppose, it must be Express type from express package or the superset of the Express.
@TokugawaTakeshi TokugawaTakeshi added flag: needs discussion Issues which needs discussion before implementation. type: feature Issues related to new features. labels Oct 1, 2023
@attilaorosz
Copy link
Member

Indeed that’s something we could improve. Could be a good task for a first contributor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flag: needs discussion Issues which needs discussion before implementation. type: feature Issues related to new features.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@attilaorosz @TokugawaTakeshi